Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec

From	Chen-Yu Tsai <wens@csie.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec
Date	2016-11-08 09:00 +0100
Message-ID	<sB9u2-6ui-29@gated-at.bofh.it> (permalink)
References	<sARQu-3wK-55@gated-at.bofh.it> <sAS0b-3Aq-73@gated-at.bofh.it> <sASWd-4ht-11@gated-at.bofh.it> <sB9u2-6ui-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Nov 8, 2016 at 3:44 PM, Maxime Ripard
<maxime.ripard@free-electrons.com> wrote:
> On Mon, Nov 07, 2016 at 10:11:45PM +0800, Chen-Yu Tsai wrote:
>> On Mon, Nov 7, 2016 at 9:08 PM, Maxime Ripard
>> <maxime.ripard@free-electrons.com> wrote:
>> > The GR8-EVB comes with a wm8978 codec connected to the i2s bus.
>> >
>> > Add a card in order to have it working
>> >
>> > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
>> > ---
>> >  arch/arm/boot/dts/ntc-gr8-evb.dts | 14 ++++++++++++++
>> >  1 file changed, 14 insertions(+), 0 deletions(-)
>> >
>> > diff --git a/arch/arm/boot/dts/ntc-gr8-evb.dts b/arch/arm/boot/dts/ntc-gr8-evb.dts
>> > index 12b4317a4383..5291e425caf9 100644
>> > --- a/arch/arm/boot/dts/ntc-gr8-evb.dts
>> > +++ b/arch/arm/boot/dts/ntc-gr8-evb.dts
>> > @@ -76,6 +76,20 @@
>> >                 default-brightness-level = <8>;
>> >         };
>> >
>> > +       i2s {
>>
>> "sound" might be a better node name? The I2S controllers are also
>> named "i2s".
>
> I know, but we also had the codec and SPDIF on this board, so sound
> was too generic to be meaningful I guess. I don't really care about
> the name though, if you have any suggestion...

Well people seem to use "sound" for the sound card nodes...

What about "sound-analog" for this one, and "sound-spdif" for the
SPDIF simple card? Or "analog-sound" and "spdif-sound" if that looks
better.


ChenYu

>> Otherwise,
>>
>> Acked-by: Chen-Yu Tsai <wens@csie.org>
>
> Thanks!
> Maxime
>
> --
> Maxime Ripard, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com

Thread

[PATCH 0/3] ARM: gr8: evb: Enable the i2s codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 14:10 +0100
  [PATCH 2/3] ASoC: wm8978: Adjust clock indices so that simple card works Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 14:10 +0100
    Applied "ASoC: wm8978: Adjust clock indices so that simple card works" to the asoc tree Mark Brown <broonie@kernel.org> - 2016-11-09 16:10 +0100
  [PATCH 3/3] ARM: gr8: evb: Add i2s codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 14:20 +0100
    Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Chen-Yu Tsai <wens@csie.org> - 2016-11-07 15:20 +0100
      Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Chen-Yu Tsai <wens@csie.org> - 2016-11-08 09:00 +0100
        Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-08 21:40 +0100
        Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-10 12:00 +0100
      Re: [PATCH 3/3] ARM: gr8: evb: Add i2s codec Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-08 09:00 +0100

csiph-web