Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1516750
| From | James Simmons <jsimmons@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong |
| Date | 2016-11-08 04:00 +0100 |
| Message-ID | <sB4NH-3p8-7@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The ldlm_pool field pl_recalc_time is set to the current
monotonic clock value but the interval period is calculated
with the wall clock. This means the interval period will
always be far larger than the pl_recalc_period, which is
just a small interval time period. The correct thing to
do is to use monotomic clock current value instead of the
wall clocks value when calculating recalc_interval_sec.
Signed-off-by: James Simmons <jsimmons@infradead.org>
---
drivers/staging/lustre/lustre/ldlm/ldlm_pool.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
index 19831c5..30d4f80 100644
--- a/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
+++ b/drivers/staging/lustre/lustre/ldlm/ldlm_pool.c
@@ -256,7 +256,7 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
time64_t recalc_interval_sec;
int ret;
- recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+ recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
if (recalc_interval_sec < pl->pl_recalc_period)
return 0;
@@ -264,7 +264,7 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
/*
* Check if we need to recalc lists now.
*/
- recalc_interval_sec = ktime_get_real_seconds() - pl->pl_recalc_time;
+ recalc_interval_sec = ktime_get_seconds() - pl->pl_recalc_time;
if (recalc_interval_sec < pl->pl_recalc_period) {
spin_unlock(&pl->pl_lock);
return 0;
@@ -301,7 +301,7 @@ static int ldlm_cli_pool_recalc(struct ldlm_pool *pl)
* Time of LRU resizing might be longer than period,
* so update after LRU resizing rather than before it.
*/
- pl->pl_recalc_time = ktime_get_real_seconds();
+ pl->pl_recalc_time = ktime_get_seconds();
lprocfs_counter_add(pl->pl_stats, LDLM_POOL_TIMING_STAT,
recalc_interval_sec);
spin_unlock(&pl->pl_lock);
--
1.7.1
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong James Simmons <jsimmons@infradead.org> - 2016-11-08 04:00 +0100
Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong "Dilger, Andreas" <andreas.dilger@intel.com> - 2016-11-09 05:00 +0100
Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong Arnd Bergmann <arnd@arndb.de> - 2016-11-09 17:10 +0100
Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-11-10 13:30 +0100
Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong Arnd Bergmann <arnd@arndb.de> - 2016-11-10 16:10 +0100
Re: [lustre-devel] [PATCH] staging: lustre: ldlm: pl_recalc time handling is wrong James Simmons <jsimmons@infradead.org> - 2016-11-10 19:10 +0100
[PATCH v2] staging: lustre: ldlm: pl_recalc time handling is wrong Arnd Bergmann <arnd@arndb.de> - 2016-11-10 16:30 +0100
Re: [PATCH v2] staging: lustre: ldlm: pl_recalc time handling is wrong James Simmons <jsimmons@infradead.org> - 2016-11-10 20:00 +0100
csiph-web