Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515727

Re: [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip

Show all headers | View raw

On 06/11/16 14:23, Brian Masney wrote:
> On Sun, Nov 06, 2016 at 12:03:53PM +0000, Jonathan Cameron wrote:
>> On 03/11/16 12:56, Brian Masney wrote:
>>> When updating the in_illuminance_calibscale and
>>> in_illuminance_integration_time sysfs attributes, these values were not
>>> actually written to the chip. The chip would continue to use the old
>>> parameters. Extracted out tsl2583_set_als_gain() and
>>> tsl2583_set_als_time() functions that are now called when these sysfs
>>> attributes are updated. The chip initialization now calls these these
>>> new functions.
>>>
>>> Rename taos_chip_on() to tsl2583_chip_init() since it is now only called
>>> during device probing and when the power management code wakes the
>>> device back up. tsl2583_chip_init() was refactored to use the new
>>> functions mentioned above.
>>>
>>> Previously, the current chip state was represented as a tristate
>>> (working, suspended, and unknown). The unknown state was not used. The
>>> chip state is now represented with a single boolean value (suspended).
>> Last part should probably have been a separate patch.  Earlier stages could
>> also have been futher broken up I think to make it easier to review.
>>
>> The additional init in the resume path should also protect against suspends
>> which actually cut the power to the chip which is nice.
>>
>> Just enough bits and pieces inline that I'd like you to do another pass
>> on this.
> 
> No problem, I'll split this one up for you. My next patch series will
> also contain a lot of trivial code cleanups, some documentation updates, and
> a request to move the driver out of staging.
Cool
> 
> The device tree documentation
> (Documentation/devicetree/bindings/iio/light/tsl2583.txt) has the
> interrupt-parent and interrupts properties as optional, however the
> driver does not support interrupts. Should I remove these properties from
> the device tree documentation? I can add the code to support the
> interrupts but I am hesistant to add that new code if no one will use it.
> 
> Brian
> 
Leave them there.  Device tree is about documenting the hardware,
not just those bits we get around to using ;)

Obviously we have to document what we use but no problem documenting
other bits!

Jonathan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] staging: iio: tsl2583: i2c cleanups Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
  [PATCH 8/9] staging: iio: tsl2583: check if chip is suspended in in_illuminance_calibrate_store Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 8/9] staging: iio: tsl2583: check if chip is suspended in  in_illuminance_calibrate_store Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:10 +0100
  [PATCH 2/9] staging: iio: tsl2583: removed unused code from device probing Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 2/9] staging: iio: tsl2583: removed unused code from  device probing Jonathan Cameron <jic23@kernel.org> - 2016-11-06 12:50 +0100
  [PATCH 6/9] staging: iio: tsl2583: remove redudant i2c call in taos_als_calibrate() Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 6/9] staging: iio: tsl2583: remove redudant i2c call in  taos_als_calibrate() Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:00 +0100
  [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to calibscale and int_time not being set on the chip Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to  calibscale and int_time not being set on the chip Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:20 +0100
      Re: [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to  calibscale and int_time not being set on the chip Brian Masney <masneyb@onstation.org> - 2016-11-06 15:30 +0100
        Re: [PATCH 7/9] staging: iio: tsl2583: fix issue with changes to  calibscale and int_time not being set on the chip Jonathan Cameron <jic23@kernel.org> - 2016-11-06 19:00 +0100
  [PATCH 1/9] staging: iio: tsl2583: i2c_smbus_write_byte() / i2c_smbus_read_byte() migration Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 1/9] staging: iio: tsl2583: i2c_smbus_write_byte() /  i2c_smbus_read_byte() migration Jonathan Cameron <jic23@kernel.org> - 2016-11-06 12:40 +0100
    Re: [PATCH 1/9] staging: iio: tsl2583: i2c_smbus_write_byte() /  i2c_smbus_read_byte() migration Jonathan Cameron <jic23@kernel.org> - 2016-11-06 12:40 +0100
  [PATCH 4/9] staging: iio: tsl2583: remove redundant power off sequence in taos_chip_on() Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 4/9] staging: iio: tsl2583: remove redundant power off  sequence in taos_chip_on() Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:00 +0100
  [PATCH 5/9] staging: iio: tsl2583: don't shutdown chip when updating the lux table Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 5/9] staging: iio: tsl2583: don't shutdown chip when  updating the lux table Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:00 +0100
  [PATCH 9/9] staging: iio: tsl2583: remove redundant write to the control register in taos_probe() Brian Masney <masneyb@onstation.org> - 2016-11-03 14:00 +0100
    Re: [PATCH 9/9] staging: iio: tsl2583: remove redundant write to the  control register in taos_probe() Jonathan Cameron <jic23@kernel.org> - 2016-11-06 13:10 +0100

csiph-web