Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515725

Re: [PATCH v4 3/5] mtd: nand: Add bb_per_die and blocks_per_die fields to nand_chip

Show all headers | View raw

On Tue, 1 Nov 2016 13:16:28 -0500
Zach Brown <zach.brown@ni.com> wrote:

> The fields bb_per_die and blocks_per_die are useful determining the
> number of bad blocks a MTD needs to allocate. How they are set will
> depend on if the chip is ONFI, JEDEC or a full-id entry in the nand_ids
> table.
> 
> Signed-off-by: Zach Brown <zach.brown@ni.com>
> ---
>  include/linux/mtd/nand.h | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> index d8905a2..3093827 100644
> --- a/include/linux/mtd/nand.h
> +++ b/include/linux/mtd/nand.h
> @@ -771,6 +771,9 @@ nand_get_sdr_timings(const struct nand_data_interface *conf)
>   *			supported, 0 otherwise.
>   * @jedec_params:	[INTERN] holds the JEDEC parameter page when JEDEC is
>   *			supported, 0 otherwise.
> + * @bb_per_die:	[INTERN] the max number of bad blocks each die of a
> + *			this nand device will encounter their life times.
> + * @blocks_per_die:	[INTERN] The number of PEBs in a die
>   * @read_retries:	[INTERN] the number of read retry modes supported
>   * @onfi_set_features:	[REPLACEABLE] set the features for ONFI nand
>   * @onfi_get_features:	[REPLACEABLE] get the features for ONFI nand
> @@ -853,6 +856,8 @@ struct nand_chip {
>  		struct nand_onfi_params	onfi_params;
>  		struct nand_jedec_params jedec_params;
>  	};
> +	u16  bb_per_die;

Why not max_bb_per_die?
And please put a single space between the type and the field name.

> +	u32  blocks_per_die;
>  
>  	struct nand_data_interface *data_interface;
>  

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/5] mtd: use ONFI bad blocks per LUN to calculate UBI bad PEB limit Zach Brown <zach.brown@ni.com> - 2016-11-01 19:20 +0100
  [PATCH v4 5/5] mtd: nand: set bb_per_die and blocks_per_die for ONFI compliant chips Zach Brown <zach.brown@ni.com> - 2016-11-01 19:20 +0100
  [PATCH v4 1/5] mtd: introduce function max_bad_blocks Zach Brown <zach.brown@ni.com> - 2016-11-01 19:20 +0100
  [PATCH v4 4/5] mtd: nand: implement 'max_bad_blocks' mtd function Zach Brown <zach.brown@ni.com> - 2016-11-01 19:20 +0100
  [PATCH v4 3/5] mtd: nand: Add bb_per_die and blocks_per_die fields to nand_chip Zach Brown <zach.brown@ni.com> - 2016-11-01 19:20 +0100
    Re: [PATCH v4 3/5] mtd: nand: Add bb_per_die and blocks_per_die  fields to nand_chip Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-06 18:50 +0100
  Re: [PATCH v4 0/5] mtd: use ONFI bad blocks per LUN to calculate  UBI bad PEB limit Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-06 19:00 +0100

csiph-web