Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk

From	Marcos Paulo de Souza <marcos.souza.org@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk
Date	2016-11-06 03:10 +0100
Message-ID	<sAl4d-7IG-5@gated-at.bofh.it> (permalink)
References	<sywwN-1Yd-1@gated-at.bofh.it> <sAdT4-2WL-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Darren,

On Sat, Nov 05, 2016 at 11:24:04AM -0700, Darren Hart wrote:
> On Mon, Oct 31, 2016 at 11:56:10PM -0200, Marcos Paulo de Souza wrote:
> > Without this patch, the Asus X45U wireless card can't be turned
> > on (hard-blocked), but after a suspend/resume it just starts working.
> > 
> > Following this bug report[1], there are other cases like this one, but
> > this Asus is the only model that I can test.
> > 
> > [1] https://ubuntuforums.org/showthread.php?t=2181558
> > 
> > Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> > Cc: <stable@vger.kernel.org>
> > 
> > ---
> > This patch applies smoothly in 4.8.6 and 4.4.29. I hope now I followed
> > the instructions correctly.
> 
> Hi Marcos,
> 
> You'll find exact steps in the stable_kernel_rules.txt document regarding how to
> annotate the commit message with Cc lines indicating to which versions this
> patch should be applied.
> 
> If, for example, you have verified that this patch is relevant only to 4.4 and
> forward, you would include:
> 
> Cc: <stable@vger.kernel.org> # 4.4.x-
> 
> But this should mean that the patch is explicitly broken or otherwise
> inappropriate for 4.3 and earlier.

Yes, I have misread the documentation. I could apply the patch as is just in
the versions 4.8.6 and 4.4.29, but maybe I could rework te patch earlier versions.

But, aside from stable tree, do you agree with this change, since it fixes the
wireless problem in this laptop?

Thanks,

> 
> Thanks,
> 
> -- 
> Darren Hart
> Intel Open Source Technology Center

Thread

[PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-01 03:00 +0100
  Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Darren Hart <dvhart@infradead.org> - 2016-11-05 19:30 +0100
    Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-06 03:10 +0100
      Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Darren Hart <dvhart@infradead.org> - 2016-11-07 19:40 +0100
        Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-07 21:20 +0100
        Re: [PATCH v2] platform/x86/asus-nb-wmi.c: Add X45U quirk Marcos Paulo de Souza <marcos.souza.org@gmail.com> - 2016-11-08 01:20 +0100

csiph-web