Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1515605

Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode

From Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Newsgroups linux.kernel
Subject Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode
Date 2016-11-05 19:50 +0100
Message-ID <sAecq-33b-9@gated-at.bofh.it> (permalink)
References <swX85-51F-25@gated-at.bofh.it> <swYQy-69J-15@gated-at.bofh.it> <sAecq-33b-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, 05 Nov 2016, Darren Hart wrote:
> On Thu, Oct 27, 2016 at 03:46:44PM -0400, Lyude wrote:
> > For whatever reason, the X1 Yoga doesn't support the normal method of
> > querying for tablet mode. Instead of providing the MHKG method under the
> > hotkey handle, we're instead given the CMMD method under the EC handle.
> > Values on this handle are either 0x1, laptop mode, or 0x6, tablet mode.
> > 
> > Changes since v1:
> > - Clarify kernel output when finding the tablet mode switch
> 
> These two lines go below the --- below (they aren't meant to be part of the
> permanent commit message). Please see Documentation/SubmittingPatches.
> 
> I've queued this to testing as it addresses Henrique's change request. Henrique,
> I'll add your Reviewed-by if you send it along, or drop it if you have more
> reservations.

No reservations, since it was tested to not regress previous thinkpads.

-- 
  Henrique Holschuh

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet  Mode Lyude Paul <lyude@redhat.com> - 2016-10-27 17:00 +0200
  Re: [PATCH] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-10-27 20:00 +0200
    [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet Mode Lyude <lyude@redhat.com> - 2016-10-27 21:50 +0200
      Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet  Mode Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2016-11-05 19:50 +0100
      Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet  Mode Darren Hart <dvhart@infradead.org> - 2016-11-05 19:50 +0100
        Re: [PATCH v2] thinkpad_acpi: Add support for X1 Yoga (2016) Tablet  Mode Darren Hart <dvhart@infradead.org> - 2016-11-05 20:00 +0100

csiph-web