[PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string

From	Heinrich Schuchardt <xypron.glpk@gmx.de>
Newsgroups	linux.kernel
Subject	[PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string
Date	2016-11-05 16:00 +0100
Message-ID	<sAaBP-IS-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

fw_rev_major and fw_rev_minor are defined as int.
Use %d to print them.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 drivers/watchdog/pcwd_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/watchdog/pcwd_pci.c b/drivers/watchdog/pcwd_pci.c
index c0d07ee..e1fbbf6 100644
--- a/drivers/watchdog/pcwd_pci.c
+++ b/drivers/watchdog/pcwd_pci.c
@@ -234,7 +234,7 @@ static void pcipcwd_show_card_info(void)
 	got_fw_rev = send_command(CMD_GET_FIRMWARE_VERSION, &fw_rev_major,
 								&fw_rev_minor);
 	if (got_fw_rev)
-		sprintf(fw_ver_str, "%u.%02u", fw_rev_major, fw_rev_minor);
+		sprintf(fw_ver_str, "%d.%02d", fw_rev_major, fw_rev_minor);
 	else
 		sprintf(fw_ver_str, "<card no answer>");
 
-- 
2.10.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-11-05 16:00 +0100
  Re: [PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string Guenter Roeck <linux@roeck-us.net> - 2016-11-05 16:30 +0100
    Re: [PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string Heinrich Schuchardt <xypron.glpk@gmx.de> - 2016-11-05 19:30 +0100
    Re: [PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string Wim Van Sebroeck <wim@iguana.be> - 2016-11-06 17:20 +0100

csiph-web