Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal string length

From	Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups	linux.kernel
Subject	Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal string length
Date	2016-11-07 20:30 +0100
Message-ID	<sAXMd-7uI-7@gated-at.bofh.it> (permalink)
References	<sARx7-3aL-3@gated-at.bofh.it> <sARx8-3aL-31@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hello Kieran,

On 11/07/2016 09:47 AM, Kieran Bingham wrote:
> If a user provides a shortened string to match a device to the sysfs i2c
> interface it will match on the first string that contains that string
> prefix.
> 
> for example:
>   echo a 0x68 > /sys/bus/i2c/devices/i2c-2/new_device
> will match as3711, as3722, and ak8975 incorrectly.
> 
> Correct this by using sysfs_streq to match the string exactly
> 
> Signed-off-by: Kieran Bingham <kieran@bingham.xyz>
> 

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Thread

[PATCHv7 00/11] i2c: Relax mandatory I2C ID table passing Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
  [PATCHv7 06/11] i2c: Provide a temporary .probe_new() call-back type Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
  [PATCHv7 05/11] i2c: Export i2c_match_id() for direct use by device drivers Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
  [PATCHv7 08/11] i2c: match vendorless strings on the internal string length Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
    Re: [PATCHv7 08/11] i2c: match vendorless strings on the internal  string length Javier Martinez Canillas <javier@osg.samsung.com> - 2016-11-07 20:30 +0100
  [PATCHv7 11/11] [TESTPATCH] rtc: convert ds1307 to interim probe_new Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
  [PATCHv7 02/11] i2c: Add the ability to match device to compatible string without an of_node Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 13:50 +0100
  [PATCHv7 01/11] i2c: Add pointer dereference protection to i2c_match_id() Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 14:00 +0100
  [PATCHv7 04/11] i2c: Make I2C ID tables non-mandatory for DT'ed devices Kieran Bingham <kieran@ksquared.org.uk> - 2016-11-07 14:00 +0100

csiph-web