Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516306

Re: [PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Michael Zoran <mzoran@crowfest.net> writes:

> The current dma_map_sg based implementation for bulk messages
> computes many offsets into a single allocation multiple times in
> both the create and free code paths.  This is inefficient,
> error prone and in fact still has a few lingering issues
> with arm64.
>
> This change replaces a small portion of that inplementation with
> new code that uses a new struct vchiq_pagelist_info to store the
> needed information rather then complex offset calculations.
>
> This improved implementation should be more efficient and easier
> to understand and maintain.
>
> Tests Run(Both Pass):
> vchiq_test -p 1
> vchiq_test -f 10

Looks good, and it's a nice cleanup.  Thanks!

Reviewed-by: Eric Anholt <eric@anholt.net>

I had one style note, which was that you're using an int and 0/1 for a
boolean value, but we like to use proper bools and true/false instead.
However, you're modifying code that was already using an int for related
booleans, so that can be a separate cleanup.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure Michael Zoran <mzoran@crowfest.net> - 2016-11-07 15:10 +0100
  Re: [PATCH v2] staging: vc04_services: add vchiq_pagelist_info structure Eric Anholt <eric@anholt.net> - 2016-11-07 17:50 +0100

csiph-web