Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1516287

Re: [PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn()

Show all headers | View raw

On 11/07/2016 08:44 AM, Anna Schumaker wrote:
> Hi Shuah,
> 
> On 11/07/2016 10:41 AM, Shuah Khan wrote:
>> Fix the following warn:
>>
>>  net/netfilter/ipvs/ip_vs_sync.c: In function ‘ip_vs_proc_sync_conn’:
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>    struct ip_vs_sync_conn_options opt;
>>                                   ^~~
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.delta’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘opt.previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).init_seq’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).delta’ may be used uninitialized in this function [-Wmaybe-uninitialized]
>>  net/netfilter/ipvs/ip_vs_sync.c:1069:33: warning: ‘*((void *)&opt+12).previous_delta’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> 
> Are you sure you put the right commit message on this patch?  The message describes a warning in ip_vs_sync.c, but the patch is for nfs4session.c.
> 
> Thanks,
> Anna

Oops. Sorry about this. Bad cut and paste from make output.
I will resend the patch with the correct changelog

thanks,
-- Shuah

> 
>>
>> Signed-off-by: Shuah Khan <shuahkh@osg.samsung.com>
>> ---
>>  fs/nfs/nfs4session.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/nfs/nfs4session.c b/fs/nfs/nfs4session.c
>> index b629730..68e700e 100644
>> --- a/fs/nfs/nfs4session.c
>> +++ b/fs/nfs/nfs4session.c
>> @@ -196,7 +196,7 @@ static int nfs4_slot_get_seqid(struct nfs4_slot_table  *tbl, u32 slotid,
>>  static bool nfs4_slot_seqid_in_use(struct nfs4_slot_table *tbl,
>>  		u32 slotid, u32 seq_nr)
>>  {
>> -	u32 cur_seq;
>> +	u32 cur_seq = 0;
>>  	bool ret = false;
>>  
>>  	spin_lock(&tbl->slot_tbl_lock);
>>
> 

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net/netfiliter: Fix used uninitialized warn in ip_vs_proc_sync_conn() Shuah Khan <shuahkh@osg.samsung.com> - 2016-11-07 16:50 +0100
  Re: [PATCH] net/netfiliter: Fix used uninitialized warn in  ip_vs_proc_sync_conn() Shuah Khan <shuahkh@osg.samsung.com> - 2016-11-07 17:20 +0100

csiph-web