Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1516282

Re: [PATCH/RFC] z3fold: use per-page read/write lock

From Andi Kleen <andi@firstfloor.org>
Newsgroups linux.kernel
Subject Re: [PATCH/RFC] z3fold: use per-page read/write lock
Date 2016-11-07 17:10 +0100
Message-ID <sAUEF-5ny-29@gated-at.bofh.it> (permalink)
References <sA9FL-6I-9@gated-at.bofh.it> <sAiJ3-62O-9@gated-at.bofh.it> <sAsfn-3Ir-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


> I understand the reinvention part but you're not quite accurate here
> with the numbers.
> 
> E. g. on x86_64:
> (gdb) p sizeof(rwlock_t)
> $1 = 8

I was talking about spinlocks which are 4 bytes.  Just use a spinlock then. 
rwlocks are usually a bad idea anyways because they often scale far worse than
spinlocks due to the bad cache line bouncing behavior, and it doesn't
make much difference unless your critical section is very long.

-Andi

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH/RFC] z3fold: use per-page read/write lock Vitaly Wool <vitalywool@gmail.com> - 2016-11-05 15:00 +0100
  Re: [PATCH/RFC] z3fold: use per-page read/write lock Andi Kleen <andi@firstfloor.org> - 2016-11-06 00:40 +0100
    Re: [PATCH/RFC] z3fold: use per-page read/write lock Vitaly Wool <vitalywool@gmail.com> - 2016-11-06 10:50 +0100
      Re: [PATCH/RFC] z3fold: use per-page read/write lock Andi Kleen <andi@firstfloor.org> - 2016-11-07 17:10 +0100
  Re: [PATCH/RFC] z3fold: use per-page read/write lock Peter Zijlstra <peterz@infradead.org> - 2016-11-10 20:40 +0100

csiph-web