Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1515974
| From | Sebastian Frias <sf84@laposte.net> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions |
| Date | 2016-11-07 11:10 +0100 |
| Message-ID | <sAP2i-1FI-49@gated-at.bofh.it> (permalink) |
| References | <szRpv-5mx-5@gated-at.bofh.it> <szRpv-5mx-31@gated-at.bofh.it> <sA8JN-80o-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi Måns,
On 11/05/2016 01:58 PM, Måns Rullgård wrote:
>> if (gigabit) {
>> - if (priv->phy_mode == PHY_INTERFACE_MODE_RGMII)
>> + if (phy_interface_is_rgmii(phydev))
>> mac_mode |= RGMII_MODE;
>>
>> mac_mode |= GMAC_MODE;
>
> As I said before, this part can/should be applied separately, although
> personally I probably wouldn't have bothered adding a single-use variable.
It was for consistency with other functions that use 'phydev', but I don't
mind making the changes.
Just to be clear, when you say "can/should be applied separately", do you
mean that this patch should not be part of a series, and that I should split
the series into separate patches?
Best regards,
Sebastian
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 19:30 +0100
[PATCH v3 1/2] net: ethernet: nb8800: Do not apply TX delay at MAC level Sebastian Frias <sf84@laposte.net> - 2016-11-04 19:30 +0100
[PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions Sebastian Frias <sf84@laposte.net> - 2016-11-04 19:30 +0100
Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions Måns Rullgård <mans@mansr.com> - 2016-11-05 14:00 +0100
Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions Sebastian Frias <sf84@laposte.net> - 2016-11-07 11:10 +0100
Re: [PATCH v3 2/2] net: ethernet: nb8800: handle all RGMII definitions Måns Rullgård <mans@mansr.com> - 2016-11-07 13:00 +0100
csiph-web