Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure
Date	Mon, 07 Nov 2016 11:10:01 +0100
Message-ID	<sAP2h-1FI-9@gated-at.bofh.it> (permalink)
References	<syfZ0-8gd-17@gated-at.bofh.it>
X-Original-To	Michael Zoran <mzoran@crowfest.net>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.7.1 (2016-10-04)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	30
Organization	linux.* mail to news gateway
X-Original-Cc	devel@driverdev.osuosl.org, daniels@collabora.com, swarren@wwwdotorg.org, lee@kernel.org, linux-kernel@vger.kernel.org, eric@anholt.net, noralf@tronnes.org, linux-rpi-kernel@lists.infradead.org, popcornmix@gmail.com, linux-arm-kernel@lists.infradead.org
X-Original-Date	Mon, 7 Nov 2016 11:03:31 +0100
X-Original-Message-ID	<20161107100331.GA19666@kroah.com>
X-Original-References	<20161031081035.22677-1-mzoran@crowfest.net>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1515967

Show key headers only | View raw

On Mon, Oct 31, 2016 at 01:10:35AM -0700, Michael Zoran wrote:
> The current dma_map_sg based implementation for bulk messages
> computes many offsets into a single allocation multiple times in
> both the create and free code paths.  This is inefficient,
> error prone and in fact still has a few lingering issues
> with arm64.
> 
> This change replaces a small portion of that inplementation with
> new code that uses a new struct vchiq_pagelist_info to store the
> needed information rather then complex offset calculations.
> 
> This improved implementation should be more efficient and easier
> to understand and maintain.
> 
> Tests Run(Both Pass):
> vchiq_test -p 1
> vchiq_test -f 10
> 
> Signed-off-by: Michael Zoran <mzoran@crowfest.net>
> ---
>  .../interface/vchiq_arm/vchiq_2835_arm.c           | 223 +++++++++++----------
>  1 file changed, 113 insertions(+), 110 deletions(-)

This doesn't apply to the tree anymore because of your previous patch :(

Can you refresh it and resend?

thanks,

greg k-h

Thread

[PATCH] staging: vc04_services: add vchiq_pagelist_info structure Michael Zoran <mzoran@crowfest.net> - 2016-10-31 09:20 +0100
  Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure Greg KH <gregkh@linuxfoundation.org> - 2016-11-07 11:10 +0100
    Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info  structure Michael Zoran <mzoran@crowfest.net> - 2016-11-07 16:50 +0100
      Re: [PATCH] staging: vc04_services: add vchiq_pagelist_info structure Greg KH <gregkh@linuxfoundation.org> - 2016-11-11 00:00 +0100

csiph-web