Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE

From	Maxime Ripard <maxime.ripard@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE
Date	2016-11-07 11:00 +0100
Message-ID	<sAOSB-1m1-9@gated-at.bofh.it> (permalink)
References	<sANtv-q8-3@gated-at.bofh.it> <sAOIV-1iM-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Mon, Nov 07, 2016 at 05:48:43PM +0800, Chen-Yu Tsai wrote:
> Hi,
> 
> On Mon, Nov 7, 2016 at 4:18 PM, LABBE Corentin
> <clabbe.montjoie@gmail.com> wrote:
> > Hello
> >
> > With CONFIG_DEBUG_TEST_DRIVER_REMOVE=y pinctrl-sunxi fail to load on the second try.
> >
> > [    3.900061] sun8i-h3-pinctrl 1c20800.pinctrl: initialized sunXi PIO driver
> > [    3.916251] gpio gpiochip1: GPIO integer space overlap, cannot add chip
> > [    3.923016] gpiochip_add_data: GPIOs 0..223 (1c20800.pinctrl) failed to register
> > [    3.931099] sun8i-h3-pinctrl: probe of 1c20800.pinctrl failed with error -16
> > [    3.944709] sun8i-h3-r-pinctrl 1f02c00.pinctrl: initialized sunXi PIO driver
> > [    3.960796] gpio gpiochip2: GPIO integer space overlap, cannot add chip
> > [    3.967594] gpiochip_add_data: GPIOs 352..383 (1f02c00.pinctrl) failed to register
> > [    3.975633] sun8i-h3-r-pinctrl: probe of 1f02c00.pinctrl failed with error -16
> >
> > Without it, all subsequent drivers fail to load.
> > Tested on Orange PI PC board.
> 
> I don't think the pinctrl drivers were designed to be removed.
> And I thought the lack of a .remove callback in the driver blocks
> the core from removing the device? Maybe I remember wrong...

Using a builtin_platform_driver should be enough to prevent it to be
removed.

Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Thread

[BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with  CONFIG_DEBUG_TEST_DRIVER_REMOVE LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-11-07 09:30 +0100
  Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE Chen-Yu Tsai <wens@csie.org> - 2016-11-07 10:50 +0100
    Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with  CONFIG_DEBUG_TEST_DRIVER_REMOVE Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 11:00 +0100
      Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with CONFIG_DEBUG_TEST_DRIVER_REMOVE Chen-Yu Tsai <wens@csie.org> - 2016-11-07 11:10 +0100
      Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with  CONFIG_DEBUG_TEST_DRIVER_REMOVE Maxime Ripard <maxime.ripard@free-electrons.com> - 2016-11-07 11:30 +0100
        Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with  CONFIG_DEBUG_TEST_DRIVER_REMOVE Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-11-07 11:30 +0100
      Re: [BUG] pinctrl: sunxi: sunxi-pinctrl fail to load with  CONFIG_DEBUG_TEST_DRIVER_REMOVE Corentin Labbe <clabbe.montjoie@gmail.com> - 2016-11-07 13:00 +0100

csiph-web