Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515875

Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c

Show all headers | View raw

On Sun, Nov 06, 2016 at 12:45:28PM +0900, Masahiro Yamada wrote:
> We generally expect headers in arch/$(ARCH)/include/asm directory
> are included from kernel sources, but facilities_src.h is not;
> it is included from the arch/s390/tools/gen_facilities.c tool.
> 
> There is no reason to expose this header to the public include path.
> Furthermore, facilities_src.h makes sure to be included only from
> gen_facilities.c by the following:
> 
>   #ifndef S390_GEN_FACILITIES_C
>   #error "This file can only be included by gen_facilities.c"
>   #endif
> 
> This check can be removed by merging the two files.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---

Both patches:
Acked-by: Heiko Carstens <heiko.carstens@de.ibm.com>

Martin, can you please pick them up?

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-06 04:50 +0100
  Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-11-07 08:10 +0100
    Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Martin Schwidefsky <schwidefsky@de.ibm.com> - 2016-11-07 11:00 +0100
      Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Paul Bolle <pebolle@tiscali.nl> - 2016-11-07 14:20 +0100
        Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Heiko Carstens <heiko.carstens@de.ibm.com> - 2016-11-07 14:40 +0100
          Re: [PATCH 2/2] s390: squash facilities_src.h into gen_facilities.c Paul Bolle <pebolle@tiscali.nl> - 2016-11-08 10:20 +0100

csiph-web