Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1515855

Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event

From Binoy Jayan <binoy.jayan@linaro.org>
Newsgroups linux.kernel
Subject Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event
Date 2016-11-07 07:00 +0100
Message-ID <sAL8l-7dK-7@gated-at.bofh.it> (permalink)
References <swMPn-6M3-3@gated-at.bofh.it> <swMZ4-74y-45@gated-at.bofh.it> <szshs-5Fc-31@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Linus,

On 3 November 2016 at 21:07, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> This is wrong.

Will change it back.

> Since that "umr_context" variable is on the stack, and you are waiting
> for it to be fully done, it really should be a completion.

Thank you for sharing your insight with wait_event and completion.

-Binoy

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v4 00/10] infiniband: Remove semaphores Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:00 +0200
  [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
    Re: [PATCH v4 05/10] IB/isert: Replace semaphore sem with completion Sagi Grimberg <sagi@grimberg.me> - 2016-10-30 22:20 +0100
  [PATCH v4 07/10] IB/mthca: Replace counting semaphore event_sem with wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
  [PATCH v4 04/10] IB/mthca: Replace semaphore poll_sem with mutex Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
  [PATCH v4 06/10] IB/hns: Replace counting semaphore event_sem with wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
  [PATCH v4 08/10] IB/mlx5: Add helper mlx5_ib_post_send_wait Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
  [PATCH v4 09/10] IB/mlx5: Replace semaphore umr_common:sem with wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
  [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-10-27 09:10 +0200
    Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Sagi Grimberg <sagi@grimberg.me> - 2016-10-30 22:30 +0100
      Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Leon Romanovsky <leon@kernel.org> - 2016-11-03 05:50 +0100
      Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-11-03 07:10 +0100
    Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Linus Torvalds <torvalds@linux-foundation.org> - 2016-11-03 16:40 +0100
      Re: [PATCH v4 10/10] IB/mlx5: Simplify completion into a wait_event Binoy Jayan <binoy.jayan@linaro.org> - 2016-11-07 07:00 +0100
  Re: [PATCH v4 00/10] infiniband: Remove semaphores Leon Romanovsky <leon@kernel.org> - 2016-10-27 09:20 +0200

csiph-web