Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1515806

Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead of "clock-freq-min-max"

Show all headers | View raw

On 11/05/2016 12:04 AM, Krzysztof Kozlowski wrote:
> On Fri, Nov 04, 2016 at 12:19:49PM +0100, Heiko Stuebner wrote:
>> Hi Jaehoon,
>>
>> Am Freitag, 4. November 2016, 19:21:30 CET schrieb Jaehoon Chung:
>>> On 11/04/2016 03:41 AM, Krzysztof Kozlowski wrote:
>>>> On Thu, Nov 03, 2016 at 03:21:32PM +0900, Jaehoon Chung wrote:
>>>>> In drivers/mmc/core/host.c, there is "max-frequency" property.
>>>>> It should be same behavior. So Use the "max-frequency" instead of
>>>>> "clock-freq-min-max".
>>>>>
>>>>> Signed-off-by: Jaehoon Chung <jh80.chung@samsung.com>
>>>>> ---
>>>>>
>>>>>  arch/arm/boot/dts/exynos3250-artik5-eval.dts | 2 +-
>>>>>  arch/arm/boot/dts/exynos3250-artik5.dtsi     | 2 +-
>>>>>  arch/arm/boot/dts/exynos3250-monk.dts        | 2 +-
>>>>>  arch/arm/boot/dts/exynos3250-rinato.dts      | 2 +-
>>>>>  4 files changed, 4 insertions(+), 4 deletions(-)
>>>>
>>>> This looks totally independent to rest of patches so it can be applied
>>>> separately without any functional impact (except lack of minimum
>>>> frequency). Is that correct?
>>>
>>> You're right. I will split the patches. And will resend.
>>> Thanks!
>>
>> I think what Krzysztof was asking was just if he can simply pick up this patch 
>> alone, as it does not require any of the previous changes.
>>
>> Same is true for the Rockchip patches I guess, so we could just take them 
>> individually into samsung/rockchip dts branches.
> 
> Yes, I wanted to get exactly this information. I couldn't find it in
> cover letter.

In drivers/mmc/core/host.c, there already is "max-frequency" property.
It's same functionality with "clock-freq-min-max". 
Minimum clock value can be fixed to 100K. because MMC core will check clock value from 400K to 100K.
But max-frequency can be difference.
If we can use "max-frequency" property, we don't need to use "clock-freq-min-max" property anymore.
I will resend the deprecated property instead of removing "clock-freq-min-max".

If you want to pick this, it's possible to pick. Then i will resend the patches without dt patches.

Best Regards,
Jaehoon Chung


> 
> Best regards,
> Krzysztof
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/13] mmc: dw_mmc: cleans the codes for dwmmc controller Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead of  "clock-freq-min-max" Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
    Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy"  instead of "clock-freq-min-max" Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-03 19:50 +0100
      Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead  of "clock-freq-min-max" Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-04 11:30 +0100
        Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead of "clock-freq-min-max" Heiko Stuebner <heiko@sntech.de> - 2016-11-04 12:30 +0100
          Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy"  instead of "clock-freq-min-max" Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-04 16:10 +0100
            Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy" instead  of "clock-freq-min-max" Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-07 01:40 +0100
              Re: [PATCH 10/13] ARM: dts: exynos: replace to "max-frequecy"  instead of "clock-freq-min-max" Krzysztof Kozlowski <krzk@kernel.org> - 2016-11-09 21:20 +0100
  [PATCH 05/13] mmc: dw_mmc: call the dw_mci_prep_stop_abort() by default Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 13/13] Documentation: synopsys-dw-mshc: remove the unused  properties Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
    Re: [PATCH 13/13] Documentation: synopsys-dw-mshc: remove the unused  properties Rob Herring <robh@kernel.org> - 2016-11-10 19:50 +0100
  [PATCH 04/13] mmc: dw_mmc: use the hold register when send stop command Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 11/13] ARM: dts: rockchip: replace to "max-frequency" instead  of "clock-freq-min-max" Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
    Re: [PATCH 11/13] ARM: dts: rockchip: replace to "max-frequency" instead of "clock-freq-min-max" Heiko Stuebner <heiko@sntech.de> - 2016-11-09 15:10 +0100
  [PATCH 09/13] mmc: dw_mmc: remove the "clock-freq-min-max" property Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
    Re: [PATCH 09/13] mmc: dw_mmc: remove the "clock-freq-min-max" property Heiko Stübner <heiko@sntech.de> - 2016-11-03 09:30 +0100
      Re: [PATCH 09/13] mmc: dw_mmc: remove the "clock-freq-min-max" property Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 09:50 +0100
  [PATCH 08/13] mmc: dw_mmc: remove the unnecessary mmc_data structure Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 12/13] ARM64: dts: rockchip: replace to "max-frequency" instead  of "clock-freq-min-max" Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
    Re: [PATCH 12/13] ARM64: dts: rockchip: replace to "max-frequency" instead of "clock-freq-min-max" Heiko Stuebner <heiko@sntech.de> - 2016-11-09 15:40 +0100
  [PATCH 03/13] mmc: dw_mmc: change the DW_MCI_FREQ_MIN from 400K to 100K Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 02/13] mmc: dw_mmc: fix the debug message for checking card's  present Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 01/13] mmc: dw_mmc: display the real register value on debugfs Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 06/13] mmc: core: move the cookie's enum values from sdhci.h to  mmc.h Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  [PATCH 07/13] mmc: dw_mmc: use the cookie's enum values for  post/pre_req() Jaehoon Chung <jh80.chung@samsung.com> - 2016-11-03 07:30 +0100
  Re: [PATCH 00/13] mmc: dw_mmc: cleans the codes for dwmmc controller Heiko Stuebner <heiko@sntech.de> - 2016-11-09 20:00 +0100

csiph-web