Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare()
Date	2016-11-07 00:00 +0100
Message-ID	<sAEzT-33D-9@gated-at.bofh.it> (permalink)
References	<sz7wl-Mi-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu,  3 Nov 2016 02:21:04 +0900
Masahiro Yamada <yamada.masahiro@socionext.com> wrote:

> The denali_dt_probe() calls clk_disable_unprepare() in the bailout
> path, whereas denali_dt_remove calls clk_disable(), inconsistently.
> Replace the latter with clk_disable_unprepare() to make sure to
> unprepare the clock.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>

Applied.

Thanks,

Boris

> ---
> 
>  drivers/mtd/nand/denali_dt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/denali_dt.c b/drivers/mtd/nand/denali_dt.c
> index 0cb1e8d..f821dc1 100644
> --- a/drivers/mtd/nand/denali_dt.c
> +++ b/drivers/mtd/nand/denali_dt.c
> @@ -110,7 +110,7 @@ static int denali_dt_remove(struct platform_device *ofdev)
>  	struct denali_dt *dt = platform_get_drvdata(ofdev);
>  
>  	denali_remove(&dt->denali);
> -	clk_disable(dt->clk);
> +	clk_disable_unprepare(dt->clk);
>  
>  	return 0;
>  }

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mtd: nand: denali_dt: replace clk_disable() with clk_disable_unprepare() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-11-02 18:30 +0100
  Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with  clk_disable_unprepare() Marek Vasut <marek.vasut@gmail.com> - 2016-11-05 08:40 +0100
  Re: [PATCH] mtd: nand: denali_dt: replace clk_disable() with  clk_disable_unprepare() Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-11-07 00:00 +0100

csiph-web