Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE

From	Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE
Date	2016-11-06 20:10 +0100
Message-ID	<sAAZk-YV-37@gated-at.bofh.it> (permalink)
References	(4 earlier) <szmOJ-261-11@gated-at.bofh.it> <sznrs-2Dk-9@gated-at.bofh.it> <szC77-3KT-1@gated-at.bofh.it> <szFom-5NS-7@gated-at.bofh.it> <sAeYN-3yw-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On Sunday 06 November 2016 01:01 AM, Anton Blanchard wrote:
> Hi,
>
>> kprobe, uprobe, hw-breakpoint and xmon are the only user of
>> emulate_step.
>>
>> Kprobe / uprobe single-steps instruction if they can't emulate it, so
>> there is no problem with them. As I mention, hw-breakpoint is broken.
>> However I'm not sure about xmon, I need to check that.
> I was mostly concerned that it would impact kprobes. Sounds like we are
> ok there.
>
>> So yes, there is no user-visible feature that depends on this.
> Aren't hardware breakpoints exposed via perf? I'd call perf
> user-visible.


Thanks Anton, That's a good catch. I tried this on ppc64le:

  $ sudo cat /proc/kallsyms  | grep pid_max
    c00000000116998c D pid_max

  $ sudo ./perf record -a --event=mem:0xc00000000116998c sleep 10


Before patch:
  It does not record any data and throws below warning.

  $ dmesg
    [  817.895573] Unable to handle hardware breakpoint. Breakpoint at 0xc00000000116998c will be disabled.
    [  817.895581] ------------[ cut here ]------------
    [  817.895588] WARNING: CPU: 24 PID: 2032 at arch/powerpc/kernel/hw_breakpoint.c:277 hw_breakpoint_handler+0x124/0x230
    ...

After patch:
  It records data properly.

  $ sudo ./perf report --stdio
    ...
    # Samples: 36  of event 'mem:0xc00000000116998c'
    # Event count (approx.): 36
    #
    # Overhead  Command        Shared Object     Symbol      
    # ........  .............  ................  .............
    #
        63.89%  kdumpctl       [kernel.vmlinux]  [k] alloc_pid
        27.78%  opal_errd      [kernel.vmlinux]  [k] alloc_pid
         5.56%  kworker/u97:4  [kernel.vmlinux]  [k] alloc_pid
         2.78%  systemd        [kernel.vmlinux]  [k] alloc_pid


-Ravi

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/3] powerpc: Emulation support for load/store instructions on LE Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-11-02 10:00 +0100
  Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Anton Blanchard <anton@samba.org> - 2016-11-02 22:10 +0100
    Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-11-03 06:50 +0100
      Re: [PATCH 1/3] powerpc: Emulation support for load/store instructions on LE Michael Ellerman <mpe@ellerman.id.au> - 2016-11-03 10:50 +0100
        Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-11-03 11:30 +0100
          Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Andrew Donnellan <andrew.donnellan@au1.ibm.com> - 2016-11-04 03:10 +0100
            Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-11-04 06:40 +0100
              Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Anton Blanchard <anton@samba.org> - 2016-11-05 20:40 +0100
                Re: [PATCH 1/3] powerpc: Emulation support for load/store  instructions on LE Ravi Bangoria <ravi.bangoria@linux.vnet.ibm.com> - 2016-11-06 20:10 +0100

csiph-web