Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1469009

Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex

From Jason Low <jason.low2@hpe.com>
Newsgroups linux.kernel
Subject Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex
Date 2016-08-24 03:30 +0200
Message-ID <s9vaV-3B2-1@gated-at.bofh.it> (permalink)
References <s9jt7-49j-1@gated-at.bofh.it> <s9mAF-6kW-7@gated-at.bofh.it> <s9mU1-6sX-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, 2016-08-23 at 09:35 -0700, Jason Low wrote:
> On Tue, 2016-08-23 at 09:17 -0700, Davidlohr Bueso wrote:
> > I have not looked at the patches yet, but are there any performance minutia
> > to be aware of?
> 
> This would remove all of the mutex architecture specific optimizations
> in the (common) fastpath, so that is one thing that could reduce
> performance. I'll run some benchmarks to see what some of the
> performance impacts of these patches would be.

I tested this patch on an 8 socket system with the high_systime AIM7
workload with diskfs. The patch provided big performance improvements in
terms of throughput in the highly contended cases.

-------------------------------------------------
|  users      | avg throughput | avg throughput |
              | without patch  | with patch     |
-------------------------------------------------
| 10 - 90     |   13,943 JPM   |   14,432 JPM   |
-------------------------------------------------
| 100 - 900   |   75,475 JPM   |  102,922 JPM   |
-------------------------------------------------
| 1000 - 1900 |   77,299 JPM   |  115,271 JPM   |
-------------------------------------------------

Unfortunately, at 2000 users, the modified kernel locked up.

# INFO: task reaim:<#> blocked for more than 120 seconds.

So something appears to be buggy.

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Peter Zijlstra <peterz@infradead.org> - 2016-08-23 15:00 +0200
  [RFC][PATCH 3/3] locking/mutex: Add lock handoff to avoid starvation Peter Zijlstra <peterz@infradead.org> - 2016-08-23 15:00 +0200
    Re: [RFC][PATCH 3/3] locking/mutex: Add lock handoff to avoid  starvation Peter Zijlstra <peterz@infradead.org> - 2016-08-23 15:00 +0200
    Re: [RFC][PATCH 3/3] locking/mutex: Add lock handoff to avoid  starvation Peter Zijlstra <peterz@infradead.org> - 2016-08-23 22:50 +0200
      Re: [RFC][PATCH 3/3] locking/mutex: Add lock handoff to avoid  starvation Peter Zijlstra <peterz@infradead.org> - 2016-08-25 10:20 +0200
  [RFC][PATCH 2/3] locking/mutex: Allow MUTEX_SPIN_ON_OWNER when DEBUG_MUTEXES Peter Zijlstra <peterz@infradead.org> - 2016-08-23 15:00 +0200
  Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Davidlohr Bueso <dave@stgolabs.net> - 2016-08-23 18:20 +0200
    Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Jason Low <jason.low2@hpe.com> - 2016-08-23 18:40 +0200
      Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Peter Zijlstra <peterz@infradead.org> - 2016-08-23 19:00 +0200
        Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Peter Zijlstra <peterz@infradead.org> - 2016-08-23 22:50 +0200
      Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Jason Low <jason.low2@hpe.com> - 2016-08-24 03:30 +0200
    Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Peter Zijlstra <peterz@infradead.org> - 2016-08-24 00:00 +0200
    Re: [RFC][PATCH 0/3] locking/mutex: Rewrite basic mutex Linus Torvalds <torvalds@linux-foundation.org> - 2016-08-24 03:30 +0200
  Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Peter Zijlstra <peterz@infradead.org> - 2016-08-23 22:40 +0200
  Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Tim Chen <tim.c.chen@linux.intel.com> - 2016-08-23 23:00 +0200
    Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Peter Zijlstra <peterz@infradead.org> - 2016-08-23 23:10 +0200
  Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Peter Zijlstra <peterz@infradead.org> - 2016-08-23 23:20 +0200
  Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Will Deacon <will.deacon@arm.com> - 2016-08-24 12:00 +0200
    Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Will Deacon <will.deacon@arm.com> - 2016-08-24 19:00 +0200
    Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Peter Zijlstra <peterz@infradead.org> - 2016-08-24 19:00 +0200
    Re: [RFC][PATCH 1/3] locking/mutex: Rework mutex::owner Peter Zijlstra <peterz@infradead.org> - 2016-08-24 19:20 +0200

csiph-web