Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1468986

Re: [PATCH net] dwc_eth_qos: fix interrupt enable race

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH net] dwc_eth_qos: fix interrupt enable race
Date 2016-08-24 02:20 +0200
Message-ID <s9u5b-2Ua-3@gated-at.bofh.it> (permalink)
References <s9l1U-5eM-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Lars Persson <lars.persson@axis.com>
Date: Tue, 23 Aug 2016 16:31:28 +0200

> From: Rabin Vincent <rabinv@axis.com>
> 
> We currently enable interrupts before we enable NAPI. If an RX interrupt
> hits before we enabled NAPI then the NAPI callback is never called and
> we leave the hardware with RX interrupts disabled, which of course leads
> us to never handling received packets.  Fix this by moving the interrupt
> enable to after we've enable NAPI and the reclaim tasklet.
> 
> Fixes: cd5e41234729 ("dwc_eth_qos: do phy_start before resetting hardware")
> Signed-off-by: Rabin Vincent <rabinv@axis.com>
> Signed-off-by: Lars Persson <larper@axis.com>

Applied.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH net] dwc_eth_qos: fix interrupt enable race Lars Persson <lars.persson@axis.com> - 2016-08-23 16:40 +0200
  Re: [PATCH net] dwc_eth_qos: fix interrupt enable race David Miller <davem@davemloft.net> - 2016-08-24 02:20 +0200

csiph-web