Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties

From	Stephen Boyd <stephen.boyd@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties
Date	2016-08-23 22:10 +0200
Message-ID	<s9qbf-ls-11@gated-at.bofh.it> (permalink)
References	<rSpXX-4yB-3@gated-at.bofh.it> <rSpXX-4yB-17@gated-at.bofh.it> <rSA70-2JT-25@gated-at.bofh.it> <s9qbf-ls-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 5, 2016 at 2:27 PM, Stephen Boyd <stephen.boyd@linaro.org> wrote:
> Quoting Peter Chen (2016-07-08 02:04:58)
>> On Thu, Jul 07, 2016 at 03:20:54PM -0700, Stephen Boyd wrote:
>> > @@ -39,6 +42,10 @@ static int ulpi_match(struct device *dev, struct device_driver *driver)
>> >       struct ulpi *ulpi = to_ulpi_dev(dev);
>> >       const struct ulpi_device_id *id;
>> >
>> > +     /* Some ULPI devices don't have a product id so rely on OF match */
>> > +     if (ulpi->id.product == 0)
>> > +             return of_driver_match_device(dev, driver);
>> > +
>>
>> How about using vendor id? It can't be 0, but pid may be 0.
>> See: http://www.linux-usb.org/usb.ids
>
> Heikki suggested a product id of 0 would mean we need to use DT
> matching. Should it be changed to vendor id instead?

Any comments here?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device properties Stephen Boyd <stephen.boyd@linaro.org> - 2016-08-23 22:10 +0200
  Re: [PATCH v2 03/22] usb: ulpi: Support device discovery via device  properties Heikki Krogerus <heikki.krogerus@linux.intel.com> - 2016-08-24 09:40 +0200

csiph-web