Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1468780
| From | Sudip Mukherjee <sudipm.mukherjee@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 2/2] staging: ks7010: fix memory leak |
| Date | 2016-08-23 21:00 +0200 |
| Message-ID | <s9p5w-7Pf-15@gated-at.bofh.it> (permalink) |
| References | <s9p5w-7Pf-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
If the firmware request failed we were just returning but we missed freeing the memory and releasing the MMC Host. Signed-off-by: Sudip Mukherjee <sudip.mukherjee@codethink.co.uk> --- drivers/staging/ks7010/ks7010_sdio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c index 7bcf1ea..86cdebe 100644 --- a/drivers/staging/ks7010/ks7010_sdio.c +++ b/drivers/staging/ks7010/ks7010_sdio.c @@ -791,7 +791,7 @@ static int ks7010_upload_firmware(struct ks_wlan_private *priv, retval = request_firmware(&fw_entry, ROM_FILE, &priv->ks_wlan_hw.sdio_card->func->dev); if (retval) - return retval; + goto error_out0; length = fw_entry->size; -- 1.9.1
Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread
[PATCH 1/2] staging: ks7010: return on failure Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 21:00 +0200 [PATCH 2/2] staging: ks7010: fix memory leak Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 21:00 +0200
csiph-web