Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

From	Michal Hocko <mhocko@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd
Date	2016-08-23 18:20 +0200
Message-ID	<s9mAG-6kW-29@gated-at.bofh.it> (permalink)
References	<s1iXf-5ai-19@gated-at.bofh.it> <s2bAm-7Up-13@gated-at.bofh.it> <s5hge-8nx-23@gated-at.bofh.it> <s7S1Y-68X-27@gated-at.bofh.it> <s9lOi-5N9-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue 23-08-16 17:27:11, Oleg Nesterov wrote:
> On 08/19, Michal Hocko wrote:
[...]
> > or we do not care about this
> > "regression"
> 
> Honestly, I do not know ;) Personally, I am always scared when it comes
> to the subtle changes like this, you can never know what can be broken.

If _you_ are scarred (after so many years of permanent exposure to this
code) then try to imagine how I am scarred when touching anything in
this area...

> And note that it can be broken 10 years later, like it happened with
> nscd ;)
> 
> But if you send the s/PF_SIGNALED/SIGNAL_GROUP_COREDUMP/ change I will
> ack it ;)

OK, I will repost

> Even if it won't really fix this nscd problem (imo), because
> I guess nscd wants to reset ->clear_child_tid even if the signal was
> sig_kernel_coredump().

Come on, have you ever seen this fine piece of software crashing?
But more seriously, I wouldn't give a damn because nscd is usually the
first thing I disable on my systems but there seem to be people who
would like to use this persistence thingy and even service restart will
break it. So I think we should plug this hole.

Anyway thanks for your review and feedback. As always it is really
appreciated!
-- 
Michal Hocko
SUSE Labs

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-12 11:50 +0200
  Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-19 15:30 +0200
    Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression         in nscd Oleg Nesterov <oleg@redhat.com> - 2016-08-23 17:30 +0200
      Re: [RFC PATCH] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-23 18:20 +0200

csiph-web