Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1468608

Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename()

From Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Newsgroups linux.kernel
Subject Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename()
Date 2016-08-23 16:50 +0200
Message-ID <s9lbz-5jv-23@gated-at.bofh.it> (permalink)
References <s9kyS-52F-33@gated-at.bofh.it> <s9kIx-563-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Aug 23, 2016 at 04:05:28PM +0200, Miklos Szeredi wrote:
> This is trivial to do:
> 
>  - add flags argument to simple_rename()
>  - check if flags doesn't have any other than RENAME_NOREPLACE
>  - assign simple_rename() to .rename2 instead of .rename
> 
> Filesystems converted:
> 
> hugetlbfs, ramfs, bpf.
> 
> Debugfs uses simple_rename() to implement debugfs_rename(), which is for
> debugfs instances to rename files internally, not for userspace filesystem
> access.  For this case pass zero flags to simple_rename().
> 
> Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename() Miklos Szeredi <mszeredi@redhat.com> - 2016-08-23 16:20 +0200
  Re: [PATCH 3/7] libfs: support RENAME_NOREPLACE in simple_rename() Greg Kroah-Hartman <gregkh@linuxfoundation.org> - 2016-08-23 16:50 +0200

csiph-web