Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1468528

Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables

From Johan Hovold <johan@kernel.org>
Newsgroups linux.kernel
Subject Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused variables
Date 2016-08-23 14:20 +0200
Message-ID <s9iQq-3TB-17@gated-at.bofh.it> (permalink)
References <rZeXL-5o9-5@gated-at.bofh.it> <rZeXN-5o9-51@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Jul 26, 2016 at 07:59:46PM +0200, Mathieu OTHACEHE wrote:
> Remove variables affected but never read.

This commit message is also incomplete. The tp_flags variable was indeed
read, even if it was always ANDed with 0.

I applied it anyway this time, and also dropped the now unused
TI_SET_SERIAL_FLAGS define that you did remove in v1.

> Signed-off-by: Mathieu OTHACEHE <m.othacehe@gmail.com>

Thanks,
Johan

Back to linux.kernel | Previous | Next | Find similar | Unroll thread


Thread

Re: [PATCH v2 06/22] usb: serial: ti_usb_3410_5052: Remove unused  variables Johan Hovold <johan@kernel.org> - 2016-08-23 14:20 +0200

csiph-web