Re: [PATCH resend] staging:xgifb:remove unused code

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH resend] staging:xgifb:remove unused code
Date	2016-08-23 12:30 +0200
Message-ID	<s9h7X-2zM-1@gated-at.bofh.it> (permalink)
References	<s9g2e-1UK-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Aug 23, 2016 at 05:17:30PM +0800, Ding Xiang wrote:
> The variable data is assigned but never used in rest code.
> 
> Signed-off-by: Ding Xiang <dingxiang@huawei.com>
> ---
>  drivers/staging/xgifb/vb_setmode.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/xgifb/vb_setmode.c b/drivers/staging/xgifb/vb_setmode.c
> index 50c8ea4..71bb9ca 100644
> --- a/drivers/staging/xgifb/vb_setmode.c
> +++ b/drivers/staging/xgifb/vb_setmode.c
> @@ -727,7 +727,6 @@ static void XGI_SetCRT1DE(unsigned short ModeIdIndex,
>  		tempax |= 0x40;
>  
>  	xgifb_reg_and_or(pVBInfo->P3d4, 0x07, ~0x42, tempax);
> -	data = xgifb_reg_get(pVBInfo->P3d4, 0x07);

But this did something with the hardware, are you sure this doesn't
break anything?  Lots of hardware works with the sequence of:
	write something
	read something to make sure the write worked.

Did you test this?

thanks,

greg k-h

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH resend] staging:xgifb:remove unused code Ding Xiang <dingxiang@huawei.com> - 2016-08-23 11:20 +0200
  Re: [PATCH resend] staging:xgifb:remove unused code Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 11:40 +0200
  Re: [PATCH resend] staging:xgifb:remove unused code Greg KH <gregkh@linuxfoundation.org> - 2016-08-23 12:30 +0200

csiph-web