Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468388

Re: [PATCH 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare

Show all headers | View raw

On 22.08.2016 23:51, Mateusz Guzik wrote:
> audit_exe_compare directly accesses mm->exe_file without making sure the
> object is stable. Fixing it using current primitives results in
> partially duplicating what proc_exe_link is doing.
>
> As such, introduce a trivial helper which can be used in both places and
> fix the func.

Looks good. Except trivial warning that test bot found.

Acked-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>

>
> Mateusz Guzik (2):
>   mm: introduce get_task_exe_file
>   audit: fix exe_file access in audit_exe_compare
>
>  fs/proc/base.c       |  7 +------
>  include/linux/mm.h   |  1 +
>  kernel/audit_watch.c |  8 +++++---
>  kernel/fork.c        | 24 ++++++++++++++++++++++++
>  4 files changed, 31 insertions(+), 9 deletions(-)
>


-- 
Konstantin

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare Mateusz Guzik <mguzik@redhat.com> - 2016-08-22 23:00 +0200
  [PATCH 1/2] mm: introduce get_task_exe_file Mateusz Guzik <mguzik@redhat.com> - 2016-08-22 23:00 +0200
  [PATCH 2/2] audit: fix exe_file access in audit_exe_compare Mateusz Guzik <mguzik@redhat.com> - 2016-08-22 23:00 +0200
  Re: [PATCH 0/2] introduce get_task_exe_file and use it to fix  audit_exe_compare Konstantin Khlebnikov <khlebnikov@yandex-team.ru> - 2016-08-23 10:50 +0200

csiph-web