Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1468401

[PATCH 2/3] perf/x86/intel/bts: Kill a silly warning

From Alexander Shishkin <alexander.shishkin@linux.intel.com>
Newsgroups linux.kernel
Subject [PATCH 2/3] perf/x86/intel/bts: Kill a silly warning
Date 2016-08-23 11:00 +0200
Message-ID <s9fIS-1yv-39@gated-at.bofh.it> (permalink)
References <s9fIR-1yv-11@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


At the moment, intel_bts will WARN() out if there is more than one
event writing to the same ring buffer, via SET_OUTPUT, and will only
send data from one event to a buffer.

There is no reason to have this warning in, so kill it.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
---
 arch/x86/events/intel/bts.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/events/intel/bts.c b/arch/x86/events/intel/bts.c
index 0b8ccff564..41975c6c2d 100644
--- a/arch/x86/events/intel/bts.c
+++ b/arch/x86/events/intel/bts.c
@@ -363,8 +363,6 @@ bts_buffer_reset(struct bts_buffer *buf, struct perf_output_handle *handle)
 		return 0;
 
 	head = handle->head & ((buf->nr_pages << PAGE_SHIFT) - 1);
-	if (WARN_ON_ONCE(head != local_read(&buf->head)))
-		return -EINVAL;
 
 	phys = &buf->buf[buf->cur_buf];
 	space = phys->offset + phys->displacement + phys->size - head;
-- 
2.8.1

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-23 11:00 +0200
  [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-23 11:00 +0200
    Re: [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-24 14:30 +0200
      Re: [PATCH 1/3] perf/x86/intel/bts: Fix confused ordering of PMU callbacks Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-24 16:20 +0200
  [PATCH 3/3] perf: Fix a race between mmap_close and set_output of AUX events Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-23 11:00 +0200
  [PATCH 2/3] perf/x86/intel/bts: Kill a silly warning Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-23 11:00 +0200
  Re: [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Vince Weaver <vince@deater.net> - 2016-08-23 18:30 +0200
    Re: [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-23 19:20 +0200
      Re: [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Vince Weaver <vince@deater.net> - 2016-08-23 23:00 +0200
        Re: [PATCH 0/3] perf, bts: Fallout from the fuzzer for perf/urgent Alexander Shishkin <alexander.shishkin@linux.intel.com> - 2016-08-24 05:50 +0200

csiph-web