Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468348

[PATCH 3/7] UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header

Show all headers | View raw

scan_pool() does not mark the PEB for scrubing when bitflips are
detected in the EC header of a free PEB (VID header region left to
0xff).
Make sure we scrub the PEB in this case.

Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>
Fixes: dbb7d2a88d2a ("UBI: Add fastmap core")
---
 drivers/mtd/ubi/fastmap.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
index ebb65ac6980f..a6ed78d14055 100644
--- a/drivers/mtd/ubi/fastmap.c
+++ b/drivers/mtd/ubi/fastmap.c
@@ -498,10 +498,11 @@ static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
 			unsigned long long ec = be64_to_cpu(ech->ec);
 			unmap_peb(ai, pnum);
 			dbg_bld("Adding PEB to free: %i", pnum);
+
 			if (err == UBI_IO_FF_BITFLIPS)
-				add_aeb(ai, free, pnum, ec, 1);
-			else
-				add_aeb(ai, free, pnum, ec, 0);
+				scrub = 1;
+
+			add_aeb(ai, free, pnum, ec, scrub);
 			continue;
 		} else if (err == 0 || err == UBI_IO_BITFLIPS) {
 			dbg_bld("Found non empty PEB:%i in pool", pnum);
-- 
2.7.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/7] UBI: various cleanup/fixes Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200
  [PATCH 1/7] UBI: fastmap: use ubi_find_volume() instead of open coding it Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200
  [PATCH 3/7] UBI: fastmap: scrub PEB when bitflips are detected in a free PEB EC header Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200
  [PATCH 2/7] UBI: fastmap: avoid multiple be32_to_cpu() when unneccesary Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200
  [PATCH 4/7] UBI: factorize code used to manipulate volumes at attach time Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200
  [PATCH 5/7] UBI: factorize destroy_av() and ubi_remove_av() code Boris Brezillon <boris.brezillon@free-electrons.com> - 2016-08-23 09:40 +0200

csiph-web