Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is dirty when munmap

From	Catalin Marinas <catalin.marinas@arm.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is dirty when munmap
Date	2016-08-25 11:40 +0200
Message-ID	<s9ZiF-7DA-5@gated-at.bofh.it> (permalink)
References	(5 earlier) <s8OSl-1ib-11@gated-at.bofh.it> <s9nQ6-76I-23@gated-at.bofh.it> <s9Cm6-8m-19@gated-at.bofh.it> <s9DLb-ZJ-5@gated-at.bofh.it> <s9UVH-4Gy-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 25, 2016 at 09:42:26AM +0800, Leizhen (ThunderTown) wrote:
> On 2016/8/24 18:30, Catalin Marinas wrote:
> >>>>>>>>>> On 2016/7/8 21:54, Catalin Marinas wrote:
> >>>>>>>>>>> ------------8<----------------
> >>>>>>>>>>> diff --git a/arch/arm64/mm/flush.c b/arch/arm64/mm/flush.c
> >>>>>>>>>>> index dbd12ea8ce68..c753fa804165 100644
> >>>>>>>>>>> --- a/arch/arm64/mm/flush.c
> >>>>>>>>>>> +++ b/arch/arm64/mm/flush.c
> >>>>>>>>>>> @@ -75,7 +75,8 @@ void __sync_icache_dcache(pte_t pte, unsigned long addr)
> >>>>>>>>>>>  	if (!page_mapping(page))
> >>>>>>>>>>>  		return;
> >>>>>>>>>>>  
> >>>>>>>>>>> -	if (!test_and_set_bit(PG_dcache_clean, &page->flags))
> >>>>>>>>>>> +	if (!test_and_set_bit(PG_dcache_clean, &page->flags) ||
> >>>>>>>>>>> +	    PageDirty(page))
> >>>>>>>>>>>  		sync_icache_aliases(page_address(page),
> >>>>>>>>>>>  				    PAGE_SIZE << compound_order(page));
> >>>>>>>>>>>  	else if (icache_is_aivivt())
> >>>>>>>>>>> ----------------8<---------------------
[...]
> > While we indeed see failures on multiple filesystem types, I wonder
> > whether this test case is actually expected to work. If I modify the
> > test to pass O_TRUNC to open(), I can no longer see failures. So any
> > standard tool that copies/creates executable files (gcc, dpkg, cp, rsync
> > etc.) wouldn't encounter such issues since they truncate the original
> > file and old page cache pages would be removed.
> > 
> > Do you have a real use-case where a task mmap's an executable file,
> > modifies it in place and expects another task to see the new
> > instructions without user-space cache maintenance?
> 
> No, it's just a test case created by testers.

In this case I propose we ignore this patch and you adjust the test to
use O_TRUNC, at least until we find a real scenario where this would
matter.

-- 
Catalin

Thread

Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-08-22 06:20 +0200
  Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap Catalin Marinas <catalin.marinas@arm.com> - 2016-08-23 19:40 +0200
    Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-08-24 03:40 +0200
    Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-08-24 11:10 +0200
      Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap Catalin Marinas <catalin.marinas@arm.com> - 2016-08-24 12:40 +0200
        Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-08-25 07:00 +0200
          Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap Catalin Marinas <catalin.marinas@arm.com> - 2016-08-25 11:40 +0200
            Re: [PATCH 1/1] arm64/hugetlb: clear PG_dcache_clean if the page is  dirty when munmap "Leizhen (ThunderTown)" <thunder.leizhen@huawei.com> - 2016-08-25 13:40 +0200

csiph-web