Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1470002
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM |
| Date | 2016-08-25 11:30 +0200 |
| Message-ID | <s9Z90-7za-19@gated-at.bofh.it> (permalink) |
| References | <s9GSK-33R-49@gated-at.bofh.it> <s9Hvs-3yl-15@gated-at.bofh.it> <s9HF7-3BB-19@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Wed, 2016-08-24 at 16:40 +0200, Alban Bedel wrote: > On Wed, 24 Aug 2016 16:30:39 +0200 > Oliver Neukum <oneukum@suse.com> wrote: > > > On Wed, 2016-08-24 at 15:52 +0200, Alban Bedel wrote: > > > + if (block != data) > > > + kfree(block); > > > > And if block == dta, what frees the memory? > > In this case this function didn't allocate any memory, so there is > nothing to free. Hi, I see. kfree() has a check for NULL, so you could drop the test, but it doesn't matter much either way. Regards Oliver
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Alban Bedel <alban.bedel@avionic-design.de> - 2016-08-24 16:00 +0200
Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Oliver Neukum <oneukum@suse.com> - 2016-08-24 16:40 +0200
Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Alban Bedel <alban.bedel@avionic-design.de> - 2016-08-24 16:50 +0200
Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Oliver Neukum <oneukum@suse.com> - 2016-08-25 11:30 +0200
Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Alban Bedel <alban.bedel@avionic-design.de> - 2016-08-25 12:10 +0200
Re: [PATCH] usbnet: ax88179_178a: Add support for writing the EEPROM Oliver Neukum <oneukum@suse.com> - 2016-08-25 12:20 +0200
csiph-web