Re: [PATCH v2 07/10] clk: qcom: Add support to enable FSM mode for votable alpha PLLs

From	Rajendra Nayak <rnayak@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 07/10] clk: qcom: Add support to enable FSM mode for votable alpha PLLs
Date	2016-08-25 11:20 +0200
Message-ID	<s9YZk-7vE-55@gated-at.bofh.it> (permalink)
References	<s4TQB-1tP-7@gated-at.bofh.it> <s4TQC-1tP-35@gated-at.bofh.it> <s9A0V-6Tr-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


On 08/24/2016 12:01 PM, Stephen Boyd wrote:
> On 08/11, Rajendra Nayak wrote:
>> diff --git a/drivers/clk/qcom/common.c b/drivers/clk/qcom/common.c
>> index f7c226a..6bf5abd 100644
>> --- a/drivers/clk/qcom/common.c
>> +++ b/drivers/clk/qcom/common.c
>> @@ -25,6 +25,14 @@
>>  #include "reset.h"
>>  #include "gdsc.h"
>>  
>> +#define PLL_LOCK_COUNT_SHIFT	8
>> +#define PLL_LOCK_COUNT_MASK	0x3f
>> +#define PLL_BIAS_COUNT_SHIFT	14
>> +#define PLL_BIAS_COUNT_MASK	0x3f
>> +#define PLL_VOTE_FSM_ENA	BIT(20)
>> +#define PLL_DYN_FSM_ENA		BIT(20)
>> +#define PLL_VOTE_FSM_RESET	BIT(21)
> 
> These appear but aren't deleted from anywhere else so I suspect
> now we have two copies of these defines somewhere? Perhaps this
> should go into common.h as well?

yes, these are used in clk-pll.c as well, so could as well move them
over to common.h instead of having two copies

> 

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2 07/10] clk: qcom: Add support to enable FSM mode for votable alpha PLLs Rajendra Nayak <rnayak@codeaurora.org> - 2016-08-11 10:50 +0200
  Re: [PATCH v2 07/10] clk: qcom: Add support to enable FSM mode for  votable alpha PLLs Stephen Boyd <sboyd@codeaurora.org> - 2016-08-24 08:40 +0200
    Re: [PATCH v2 07/10] clk: qcom: Add support to enable FSM mode for  votable alpha PLLs Rajendra Nayak <rnayak@codeaurora.org> - 2016-08-25 11:20 +0200

csiph-web