Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1469834
| From | Bart Van Assche <Bart.VanAssche@sandisk.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h |
| Date | 2016-08-25 07:10 +0200 |
| Message-ID | <s9V5o-50Y-11@gated-at.bofh.it> (permalink) |
| References | <s92iC-1rh-5@gated-at.bofh.it> <s92iC-1rh-17@gated-at.bofh.it> <s9kpb-4K7-19@gated-at.bofh.it> <s9kSd-5aF-9@gated-at.bofh.it> <s9qNY-Dm-23@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 08/23/16 13:42, Mikko Rapeli wrote: > On Tue, Aug 23, 2016 at 02:28:19PM +0000, Bart Van Assche wrote: >> On 08/23/16 06:57, Bart Van Assche wrote: >>> On 08/22/16 11:32, Mikko Rapeli wrote: >>>> - * uint32_t (*get_region_size)(struct dm_dirty_log *log); >>>> + * __u32 (*get_region_size)(struct dm_dirty_log *log); >>> >>> uint32_t is a type that is defined by ANSI C but __u32 not. So this >>> change looks wrong to me. Would it have been sufficient to add "#include >>> <linux/types.h>" and keep the uint32_t etc. type names? >> >> Answering my own question: adding "#include <linux/types.h>" wouldn't be >> sufficient. How about adding the following code that also occurs in a >> few other uapi header files? >> >> #ifndef __KERNEL__ >> #include <stdint.h> >> #endif >> #include <linux/types.h> > > I have tried that before but I was instructed to use the linux/types.h > versions. For example https://lkml.org/lkml/2015/6/1/160 > > But lately drm and fuse and some others have questioned this approach and > would like to use/continue using C99 stdint.h types. Hello Mikko, Thanks for the feedback. I have a minor comment though about your patch: are you aware that you have changed uint64_t into __u64 in source code comments but that int64_t has not been changed into __s64? Bart.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-22 20:40 +0200
Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-23 16:00 +0200
Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-23 16:30 +0200
Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-23 22:50 +0200
Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-25 07:10 +0200
Re: [dm-devel] [PATCH v05 04/72] dm-log-userspace.h: use __u32, __s32 and __u64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-25 09:50 +0200
[PATCH v06] uapi dm-log-userspace.h: use __u32, __s32, __u64 and __s64 from linux/types.h Mikko Rapeli <mikko.rapeli@iki.fi> - 2016-08-28 08:50 +0200
Re: [PATCH v06] uapi dm-log-userspace.h: use __u32, __s32, __u64 and __s64 from linux/types.h Bart Van Assche <Bart.VanAssche@sandisk.com> - 2016-08-28 18:10 +0200
csiph-web