Re: Memory (skb) leak in kernel 4.8-rc2

From	Larry Finger <Larry.Finger@lwfinger.net>
Newsgroups	linux.kernel
Subject	Re: Memory (skb) leak in kernel 4.8-rc2
Date	2016-08-24 22:10 +0200
Message-ID	<s9MEN-7el-7@gated-at.bofh.it> (permalink)
References	<s7ZmN-2og-11@gated-at.bofh.it> <s87DH-7Jv-9@gated-at.bofh.it> <s88Jr-8m3-1@gated-at.bofh.it> <s8zTj-d9-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 08/21/2016 07:09 AM, Frederic Dalleau wrote:
> Hi Marcel, Johan,
>
>>>> I am unable to unload module bluetooth to verify that the second
>>>> leak is not a false positive; however, the one in btusb is a real
>>>> memory leak.
>
> There was a bugzilla last week with that backtrace:
> https://bugzilla.kernel.org/show_bug.cgi?id=120691
>
> At the time, I was thinking that the leak could originate from one of the
> req_complete_skb callback, but which one?
>
> And today that the issue has popped again, I found that hci_req_sync_complete
> references the skb in hdev->req_skb. It is called (via hci_req_run_skb) from
> either __hci_cmd_sync_ev which will pass the skb to the caller, or
> __hci_req_sync which leaks.
>
> I have a patch on the grill.

Frédéric,

Any progress on this patch?

Thanks,

Larry

Thread

Memory (skb) leak in kernel 4.8-rc2 Larry Finger <Larry.Finger@lwfinger.net> - 2016-08-19 23:20 +0200
  Re: Memory (skb) leak in kernel 4.8-rc2 Marcel Holtmann <marcel@holtmann.org> - 2016-08-20 08:10 +0200
    Re: Memory (skb) leak in kernel 4.8-rc2 Johan Hedberg <johan.hedberg@gmail.com> - 2016-08-20 09:20 +0200
      Re: Memory (skb) leak in kernel 4.8-rc2 Frederic Dalleau <frederic.dalleau@collabora.co.uk> - 2016-08-21 14:20 +0200
        Re: Memory (skb) leak in kernel 4.8-rc2 Larry Finger <Larry.Finger@lwfinger.net> - 2016-08-24 22:10 +0200
          Re: Memory (skb) leak in kernel 4.8-rc2 Frederic Dalleau <frederic.dalleau@collabora.co.uk> - 2016-08-25 08:40 +0200
            Re: Memory (skb) leak in kernel 4.8-rc2 Larry Finger <Larry.Finger@lwfinger.net> - 2016-08-25 17:30 +0200
    Re: Memory (skb) leak in kernel 4.8-rc2 Larry Finger <Larry.Finger@lwfinger.net> - 2016-08-20 18:30 +0200

csiph-web