Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Oleg Nesterov <oleg@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd
Date	Wed, 24 Aug 2016 17:40:02 +0200
Message-ID	<s9Irv-4bS-13@gated-at.bofh.it> (permalink)
References	<s9mAG-6kW-25@gated-at.bofh.it> <s9n3J-6xg-55@gated-at.bofh.it> <s9BzH-80z-5@gated-at.bofh.it>
X-Original-To	Michal Hocko <mhocko@kernel.org>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.18 (2008-05-17)
X-Scanned-By	MIMEDefang 2.68 on 10.5.11.23
X-Greylist	Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Wed, 24 Aug 2016 15:32:26 +0000 (UTC)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	21
Organization	linux.* mail to news gateway
X-Original-Cc	Andrew Morton <akpm@linux-foundation.org>, linux-mm@kvack.org, LKML <linux-kernel@vger.kernel.org>, Roland McGrath <roland@hack.frob.com>, Andreas Schwab <schwab@suse.com>, William Preston <wpreston@suse.com>
X-Original-Date	Wed, 24 Aug 2016 17:32:00 +0200
X-Original-Message-ID	<20160824153159.GA25033@redhat.com>
X-Original-References	<1471968749-26173-1-git-send-email-mhocko@kernel.org> <20160823163233.GA7123@redhat.com> <20160824081023.GE31179@dhcp22.suse.cz>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1469547

Show key headers only | View raw

On 08/24, Michal Hocko wrote:
>
> Sounds better?
> diff --git a/kernel/fork.c b/kernel/fork.c
> index b89f0eb99f0a..ddde5849df81 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -914,7 +914,8 @@ void mm_release(struct task_struct *tsk, struct mm_struct *mm)
>  
>  	/*
>  	 * Signal userspace if we're not exiting with a core dump
> -	 * or a killed vfork parent which shouldn't touch this mm.
> +	 * because we want to leave the value intact for debugging
> +	 * purposes.
>  	 */
>  	if (tsk->clear_child_tid) {
>  		if (!(tsk->signal->flags & SIGNAL_GROUP_COREDUMP) &&

Yes, thanks Michal!

Acked-by: Oleg Nesterov <oleg@redhat.com>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in nscd Michal Hocko <mhocko@kernel.org> - 2016-08-23 18:20 +0200
  Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in         nscd Oleg Nesterov <oleg@redhat.com> - 2016-08-23 18:50 +0200
    Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-24 10:20 +0200
      Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-24 17:40 +0200
        Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in  nscd Michal Hocko <mhocko@kernel.org> - 2016-08-31 08:50 +0200
      Re: [PATCH v2] kernel/fork: fix CLONE_CHILD_CLEARTID regression in         nscd Oleg Nesterov <oleg@redhat.com> - 2016-08-24 17:40 +0200

csiph-web