Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469551

Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document

Show all headers | View raw

Hi Rob,

On 08/23/2016 08:32 PM, Rob Herring wrote:
> On Fri, Aug 19, 2016 at 06:53:19PM +0300, Stanimir Varbanov wrote:
>> Add devicetree binding document for Venus remote processor.
>>
>> Signed-off-by: Stanimir Varbanov <stanimir.varbanov@linaro.org>
>> ---
>>  .../devicetree/bindings/remoteproc/qcom,venus.txt  | 33 ++++++++++++++++++++++
>>  1 file changed, 33 insertions(+)
>>  create mode 100644 Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>> new file mode 100644
>> index 000000000000..06a2db60fa38
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,venus.txt
>> @@ -0,0 +1,33 @@
>> +Qualcomm Venus Peripheral Image Loader
>> +
>> +This document defines the binding for a component that loads and boots firmware
>> +on the Qualcomm Venus remote processor core.
> 
> This does not make sense to me. Venus is the video encoder/decoder h/w, 
> right? Why is the firmware loader separate from the codec block? Why 
> rproc is used? Are there multiple clients? Naming it rproc_venus implies 
> there aren't. And why does the firmware loading need 8MB of memory at a 
> fixed address?
> 

The firmware for Venus case is 5MB. And here is 8MB because of
dma_alloc_from_coherent size restriction.

The address is not really fixed, cause the firmware could support
relocation. In this example I just picked up the next free memory region
in memory-reserved from msm8916.dtsi.

regards,
Stan

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/4] Venus remoteproc driver Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-19 18:00 +0200
  [PATCH 4/4] remoteproc: qcom: add Venus video core firmware loader driver Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-19 18:00 +0200
  [PATCH 1/4] firmware: qcom: scm: add a video command for state setting Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-19 18:00 +0200
  [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-19 18:00 +0200
    Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Rob Herring <robh@kernel.org> - 2016-08-23 19:40 +0200
      Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-23 20:30 +0200
      Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Stanimir Varbanov <svarbanov@mm-sol.com> - 2016-08-24 17:50 +0200
        Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-25 07:20 +0200
          Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-25 13:20 +0200
            Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-27 00:30 +0200
              Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-29 13:50 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-08-30 19:20 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-09-01 17:00 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Andy Gross <andy.gross@linaro.org> - 2016-09-01 23:20 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding document Marek Szyprowski <m.szyprowski@samsung.com> - 2016-09-02 14:00 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Bjorn Andersson <bjorn.andersson@linaro.org> - 2016-09-02 22:20 +0200
                Re: [PATCH 3/4] dt-binding: remoteproc: venus rproc dt binding  document Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-09-07 14:00 +0200
  [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-19 18:00 +0200
    Re: [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table "Gupta, Puja" <pujag@codeaurora.org> - 2016-08-24 20:50 +0200
      Re: [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table Stanimir Varbanov <stanimir.varbanov@linaro.org> - 2016-08-25 11:20 +0200
      Re: [PATCH 2/4] firmware: qcom: scm: add iommu scm calls for pg table Andy Gross <andy.gross@linaro.org> - 2016-08-30 23:20 +0200

csiph-web