Re: [PATCH] drm/tegra: Fix window[0] base address corruption

From	Thierry Reding <thierry.reding@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] drm/tegra: Fix window[0] base address corruption
Date	2016-08-24 16:20 +0200
Message-ID	<s9Hc5-3pN-1@gated-at.bofh.it> (permalink)
References	<s8wVr-6Pf-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Sun, Aug 21, 2016 at 11:57:58AM +0300, Dmitry Osipenko wrote:
> Window uses shared stride for UV planes and tegra_dc_window struct
> defines array of 2 strides per window. That's not taken in account
> during setting up of the window addresses and strides, resulting in
> out-of-bounds write of the 3-rd (non-existent) V plane stride that
> overwrites Y plane base address.
> 
> Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
> ---
>  drivers/gpu/drm/tegra/dc.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)

Applied and added a comment to the code why it is safe to do this.

Thanks,
Thierry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] drm/tegra: Fix window[0] base address corruption Dmitry Osipenko <digetx@gmail.com> - 2016-08-21 11:10 +0200
  Re: [PATCH] drm/tegra: Fix window[0] base address corruption Thierry Reding <thierry.reding@gmail.com> - 2016-08-24 16:20 +0200

csiph-web