Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.

From	Heiko Stübner <heiko@sntech.de>
Newsgroups	linux.kernel
Subject	Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization.
Date	2016-08-24 17:00 +0200
Message-ID	<s9HOO-3F4-29@gated-at.bofh.it> (permalink)
References	<s5Jct-38n-7@gated-at.bofh.it> <s9mAF-6kW-1@gated-at.bofh.it> <s9HlL-3tn-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Arvind,

Am Mittwoch, 24. August 2016, 19:52:45 schrieb arvind Yadav:
> yes, I am referring this code for clock control.

Please definitly do not use that old gate driver anymore!

Instead please look at the real clock drivers for specific Rockchip socs in the 
same directory.
Which Rockchip soc are you working on?


Heiko

> On Tuesday 23 August 2016 09:45 PM, Heiko Stübner wrote:
> > Hi Arvind,
> > 
> > Am Samstag, 13. August 2016, 20:56:18 schrieb Arvind Yadav:
> >> -check return of 'of_iomap'.if It's falied to remap then abort.
> >> 
> >> -Unmap a region obtained by remap. iounmap frees the mapping when failed
> >> to allocate the memory.
> >> 
> >> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> >> ---
> >> 
> >>   drivers/clk/rockchip/clk-rockchip.c | 7 ++++++-
> > 
> > I've applied the patch, after rewording both patch subject and message
> > [0].
> > 
> > That driver is deprecated for quite some time, see
> > Documenation/devicetree/bindings/clock/rockchip.txt - so I'm hoping this
> > is
> > more of a random find and you're not actually using it?
> > 
> > 
> > Thanks
> > Heiko
> > 
> > [0]
> > https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/com
> > mit/?id=023a8280b8355a0aebe094299afec8d8b7b264cd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization. Arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-08-13 17:40 +0200
  Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization. Heiko Stübner <heiko@sntech.de> - 2016-08-23 18:20 +0200
    Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock  initialization. arvind Yadav <arvind.yadav.cs@gmail.com> - 2016-08-24 16:30 +0200
      Re: [v.1] clk:clk-rockchip:-of_iomap failed to remap then abort clock initialization. Heiko Stübner <heiko@sntech.de> - 2016-08-24 17:00 +0200

csiph-web