Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data
Date	2016-08-24 15:40 +0200
Message-ID	<s9Gzp-2Q5-45@gated-at.bofh.it> (permalink)
References	<s9A0V-6Tr-3@gated-at.bofh.it> <s9A0V-6Tr-1@gated-at.bofh.it> <s9FtE-2aP-43@gated-at.bofh.it> <s9FDk-2fA-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Mittwoch, den 24.08.2016, 21:29 +0900 schrieb Masahiro Yamada:
[...]
> >> @@ -285,6 +286,45 @@ static const struct reset_control_ops uniphier_reset_ops = {
> >>       .status = uniphier_reset_status,
> >>  };
> >>
> >> +static int uniphier_reset_probe(struct platform_device *pdev)
> >> +{
> >> +     struct device *dev = &pdev->dev;
> >> +     struct uniphier_reset_priv *priv;
> >> +     const struct uniphier_reset_data *p, *data;
> >> +     struct regmap *regmap;
> >> +     struct device_node *parent;
> >> +     unsigned int nr_resets = 0;
> >> +
> >> +     data = of_device_get_match_data(dev);
> >> +     WARN_ON(!data);
> >
> > I know right now this can't happen anyway, but you did return -EINVAL
> > here before. Maybe use:
> >
> >         if (WARN_ON(!data))
> >                 return -EINVAL;
> >
> > instead? I can fix it up if you agree.
> 
> I agree.
> 
> Please fix it up.  Thanks!

Ok, done.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] reset: uniphier: use of_device_get_match_data() to get matched data Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-24 08:40 +0200
  Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to  get matched data Philipp Zabel <p.zabel@pengutronix.de> - 2016-08-24 14:30 +0200
    Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to  get matched data Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-08-24 14:40 +0200
      Re: [PATCH 2/2] reset: uniphier: use of_device_get_match_data() to  get matched data Philipp Zabel <p.zabel@pengutronix.de> - 2016-08-24 15:40 +0200

csiph-web