Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469464

Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name

Show all headers | View raw

On Wed, Aug 24, 2016 at 06:58:11PM +0800, Herbert Xu wrote:
> On Fri, Aug 19, 2016 at 03:42:55PM +0200, LABBE Corentin wrote:
> > The driver name is displayed each time differently.
> > This patch make use of the same name everywhere.
> > 
> > Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>
> > ---
> >  drivers/char/hw_random/amd-rng.c | 13 ++++++-------
> >  1 file changed, 6 insertions(+), 7 deletions(-)
> > 
> > diff --git a/drivers/char/hw_random/amd-rng.c b/drivers/char/hw_random/amd-rng.c
> > index d0042f5..d0a806a 100644
> > --- a/drivers/char/hw_random/amd-rng.c
> > +++ b/drivers/char/hw_random/amd-rng.c
> > @@ -31,7 +31,7 @@
> >  #include <linux/delay.h>
> >  #include <asm/io.h>
> >  
> > -#define PFX	KBUILD_MODNAME ": "
> > +#define DRV_NAME "AMD768-HWRNG"
> >  
> >  /*
> >   * Data for PCI driver interface
> > @@ -98,7 +98,7 @@ static void amd_rng_cleanup(struct hwrng *rng)
> >  }
> >  
> >  static struct hwrng amd_rng = {
> > -	.name		= "amd",
> > +	.name		= DRV_NAME,
> 
> Hmm, this changes a sysfs-exported name which has the potential
> to break user-space.  So I think you'd need to a stronger argument
> to do it other than just cleaning it up.
> 

amd is really really too generic.

But if you still NACK that (and I understand perfectly why), I will update my series.

Regards

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/5] hwrng: amd: Fix style problem with blank line LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-19 16:00 +0200
  [PATCH 2/5] hwrng: amd: use the BIT macro LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-19 16:00 +0200
  [PATCH 3/5] hwrng: amd: Be consitent with the driver name LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-19 16:00 +0200
    Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name Herbert Xu <herbert@gondor.apana.org.au> - 2016-08-24 13:00 +0200
      Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-24 16:00 +0200
        Re: [PATCH 3/5] hwrng: amd: Be consitent with the driver name Herbert Xu <herbert@gondor.apana.org.au> - 2016-08-25 07:10 +0200
  [PATCH 4/5] hwrng: amd: Remove asm/io.h LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-19 16:00 +0200
  [PATCH 5/5] hwrng: amd: Rework of the amd768-hwrng driver LABBE Corentin <clabbe.montjoie@gmail.com> - 2016-08-19 16:00 +0200

csiph-web