Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1469368

Re: include/linux/io-mapping.h:130:39: error: implicit declaration of function 'ioremap_wc'

Show all headers | View raw

On Tue, Aug 23, 2016 at 10:03 PM, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> On Tue, Aug 16, 2016 at 10:14:57AM +0200, Linus Walleij wrote:
>> On Mon, Aug 15, 2016 at 5:08 PM, kbuild test robot

>> I think I've finally fixed this now by making OF_GPIO depend on !NO_IOMEM.
>
> I've stumbled over this patch

(...)
>     Fix this by including <linux/io-mapping.h> explicitly.
>
> having touched io-mapping.h
>
> The original patch is incorrect as io-mapping.h is not the right header
> for iounmap() - that is #include <linux/io.h> (pulling in <asm/io.h>)
> which is (and was) already present.

You're right, I'll revert this patch.

> So the root cause here is arch/um not supplying enough stubs?

arch/um is explicitly not supporting IOMEM so anyone code
using iomap()/iounmap() have to make sure they do not get
compiled on UM.

> But in the
> meantime, do you mind removing the incorrect include now that you have a
> w/a to keep 0day quiet? :)

OK

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

include/linux/io-mapping.h:130:39: error: implicit declaration of  function 'ioremap_wc' kbuild test robot <fengguang.wu@intel.com> - 2016-08-15 17:20 +0200
  Re: include/linux/io-mapping.h:130:39: error: implicit declaration of  function 'ioremap_wc' Linus Walleij <linus.walleij@linaro.org> - 2016-08-16 10:20 +0200
    Re: include/linux/io-mapping.h:130:39: error: implicit declaration  of function 'ioremap_wc' Chris Wilson <chris@chris-wilson.co.uk> - 2016-08-23 22:10 +0200
      Re: include/linux/io-mapping.h:130:39: error: implicit declaration of  function 'ioremap_wc' Linus Walleij <linus.walleij@linaro.org> - 2016-08-24 14:00 +0200

csiph-web