Re: [PATCH] [media] m2m-deinterlace: Fix error print during probe

From	Sakari Ailus <sakari.ailus@iki.fi>
Newsgroups	linux.kernel
Subject	Re: [PATCH] [media] m2m-deinterlace: Fix error print during probe
Date	2016-08-24 12:30 +0200
Message-ID	<s9DBw-UW-11@gated-at.bofh.it> (permalink)
References	<s9kfw-4GF-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi, Peter!

On Tue, Aug 23, 2016 at 04:39:39PM +0300, Peter Ujfalusi wrote:
> v4l2_err() can not be used for printing error for missing interleaved
> support in DMA as this point the pcdev->v4l2_dev is not valid.
> 
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com>
> ---
>  drivers/media/platform/m2m-deinterlace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/m2m-deinterlace.c b/drivers/media/platform/m2m-deinterlace.c
> index 0fcb5c78031d..5a5dec348f4d 100644
> --- a/drivers/media/platform/m2m-deinterlace.c
> +++ b/drivers/media/platform/m2m-deinterlace.c
> @@ -1016,7 +1016,7 @@ static int deinterlace_probe(struct platform_device *pdev)
>  		return -ENODEV;
>  
>  	if (!dma_has_cap(DMA_INTERLEAVE, pcdev->dma_chan->device->cap_mask)) {
> -		v4l2_err(&pcdev->v4l2_dev, "DMA does not support INTERLEAVE\n");
> +		dev_err(&pdev->dev, "DMA does not support INTERLEAVE\n");
>  		goto rel_dma;
>  	}
>  

Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>

-- 
Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] [media] m2m-deinterlace: Fix error print during probe Peter Ujfalusi <peter.ujfalusi@ti.com> - 2016-08-23 15:50 +0200
  Re: [PATCH] [media] m2m-deinterlace: Fix error print during probe Sakari Ailus <sakari.ailus@iki.fi> - 2016-08-24 12:30 +0200

csiph-web