[tip:perf/core] perf hists browser: Remove superfluous null check on map

Path	csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.mixmin.net!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	tip-bot for Colin Ian King <tipbot@zytor.com>
Newsgroups	linux.kernel
Subject	[tip:perf/core] perf hists browser: Remove superfluous null check on map
Date	Wed, 24 Aug 2016 11:30:02 +0200
Message-ID	<s9CFs-gj-9@gated-at.bofh.it> (permalink)
References	<s6sVY-7S0-25@gated-at.bofh.it>
X-Original-To	linux-tip-commits@vger.kernel.org
Reply-To	peterz@infradead.org, namhyung@kernel.org, colin.king@canonical.com, hpa@zytor.com, wangnan0@huawei.com, acme@redhat.com, penberg@kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org
Git-Commit-ID	6637e6f1ac62e62a353612844db21cff9a17758b
X-Mailer	tip-git-log-daemon
Robot-ID	<tip-bot.git.kernel.org>
Robot-Unsubscribe	Contact <mailto:hpa@kernel.org> to get blacklisted from these emails
MIME-Version	1.0
Content-Transfer-Encoding	8bit
Content-Type	text/plain; charset=UTF-8
Content-Disposition	inline
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	39
Organization	linux.* mail to news gateway
X-Original-Cc	jolsa@kernel.org, mingo@kernel.org, linux-kernel@vger.kernel.org, alexander.shishkin@linux.intel.com, tglx@linutronix.de, hpa@zytor.com, colin.king@canonical.com, penberg@kernel.org, wangnan0@huawei.com, acme@redhat.com, peterz@infradead.org, namhyung@kernel.org
X-Original-Date	Wed, 24 Aug 2016 02:24:55 -0700
X-Original-Message-ID	<tip-6637e6f1ac62e62a353612844db21cff9a17758b@git.kernel.org>
X-Original-References	<1471278343-14999-1-git-send-email-colin.king@canonical.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1469257

Show key headers only | View raw

Commit-ID:  6637e6f1ac62e62a353612844db21cff9a17758b
Gitweb:     http://git.kernel.org/tip/6637e6f1ac62e62a353612844db21cff9a17758b
Author:     Colin Ian King <colin.king@canonical.com>
AuthorDate: Mon, 15 Aug 2016 17:25:43 +0100
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 23 Aug 2016 15:37:33 -0300

perf hists browser: Remove superfluous null check on map

'map' is being already checked if it is NULL at the start of
do_zoom_dso(), so the second subsequent check is superfluous and can be
removed.

Signed-off-by: Colin King <colin.king@canonical.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Pekka Enberg <penberg@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Wang Nan <wangnan0@huawei.com>
Link: http://lkml.kernel.org/r/1471278343-14999-1-git-send-email-colin.king@canonical.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/ui/browsers/hists.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/perf/ui/browsers/hists.c b/tools/perf/ui/browsers/hists.c
index 22e48a3..f0611c9 100644
--- a/tools/perf/ui/browsers/hists.c
+++ b/tools/perf/ui/browsers/hists.c
@@ -2440,8 +2440,6 @@ do_zoom_dso(struct hist_browser *browser, struct popup_action *act)
 		browser->hists->dso_filter = NULL;
 		ui_helpline__pop();
 	} else {
-		if (map == NULL)
-			return 0;
 		ui_helpline__fpush("To zoom out press ESC or ENTER + \"Zoom out of %s DSO\"",
 				   __map__is_kernel(map) ? "the Kernel" : map->dso->short_name);
 		browser->hists->dso_filter = map->dso;

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] perf hists browser: remove superfluous null check on map Colin King <colin.king@canonical.com> - 2016-08-15 18:30 +0200
  Re: [PATCH] perf hists browser: remove superfluous null check on map Namhyung Kim <namhyung@kernel.org> - 2016-08-16 17:40 +0200
  [tip:perf/core] perf hists browser: Remove superfluous null check  on map tip-bot for Colin Ian King <tipbot@zytor.com> - 2016-08-24 11:30 +0200

csiph-web