Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468221

Re: perf: fuzzer crashes immediately on AMD system

Show all headers | View raw

On Mon, 22 Aug 2016, Huang Rui wrote:

> Hi Peter, Vince
> 
> On Fri, Aug 19, 2016 at 12:01:30PM +0200, Peter Zijlstra wrote:
> > On Thu, Aug 18, 2016 at 10:46:31AM -0400, Vince Weaver wrote:
> > > On Thu, 18 Aug 2016, Vince Weaver wrote:
> > > 
> > > > Tried the perf_fuzzer on my A10 fam15h/model13h system with 4.8-rc2 and it
> > > > falls over more or less immediately.
> > > > 
> > > > This maps to variable_test_bit()
> > > > 	called by ctx = find_get_context(pmu, task, event);
> > > > 		in kernel/events/core.c:9467
> > > > 
> > > > It happens quickly enough I can probably track down the exact event that 
> > > > causes this, if needed.
> > > 
> > > I have a one line reproducer:
> > > 
> > > 	perf stat -a -e amd_nb/config=0x37,config1=0x20/ /bin/ls
> > 
> > OK, cannot reproduce on my fam15h/model1h. I'll go dig through the
> > various manuals to see if I can spot the fail.
> > 
> > Huang could you either prod someone at AMD or do yourself, audit the AMD
> > perf code for all the various new models?
> 
> Actually, there might be some NBPMC event changes between model 0h-fh and
> model 10h-1fh. Below are the documents of these two processors:
> 
> http://support.amd.com/TechDocs/42301_15h_Mod_00h-0Fh_BKDG.pdf
> http://support.amd.com/TechDocs/42300_15h_Mod_10h-1Fh_BKDG.pdf
> 
> In section 3.16, it describes usage of NB Performance Counter Events.

I don't think it's the hardware that's causing the problem.

I've wasted a lot more time on it, and finally figured out how the "bt" 
instruction works, so the assembly more or less makes sense.

The problem is the per-cpu amd_uncore struct is being over-written with 
kernel memory addresses.

This makes uncore[0]->cpu a large number (it's often, but not always, the 
per-cpu address of uncore[1]->cpu) which leads to the GPF.

I can't figure out what piece of code is overwriting things though.

And to make things complicated, I think the 
	amd_uncore_find_online_sibling()
function is broken.  The code could really use more commenting, but I 
think it is designed so all siblings share one single amd_uncore 
structure, but in practice it looks like this doesn't work due to the way 
the list iterator works.

Vince

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-18 16:50 +0200
  Re: perf: fuzzer crashes immediately on AMD system Peter Zijlstra <peterz@infradead.org> - 2016-08-19 12:10 +0200
    Re: perf: fuzzer crashes immediately on AMD system Peter Zijlstra <peterz@infradead.org> - 2016-08-19 13:00 +0200
    Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-19 17:10 +0200
      Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-19 18:40 +0200
    Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-20 06:50 +0200
    Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-23 03:20 +0200
      Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-23 05:00 +0200
        Re: perf: fuzzer crashes immediately on AMD system Peter Zijlstra <peterz@infradead.org> - 2016-08-23 10:50 +0200
          Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-23 14:10 +0200
            Re: perf: fuzzer crashes immediately on AMD system Ingo Molnar <mingo@kernel.org> - 2016-08-24 11:30 +0200
              Re: perf: fuzzer crashes immediately on AMD system Vince Weaver <vincent.weaver@maine.edu> - 2016-08-24 15:30 +0200

csiph-web