Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1468126

[RESEND][PATCH 2/7 v4] k3dma: Fix hisi burst clipping

Show all headers | View raw

From: Andy Green <andy.green@linaro.org>

Max burst len is a 4-bit field, but at the moment it's clipped with
a 5-bit constant... reduce it to that which can be expressed

Cc: Zhangfei Gao <zhangfei.gao@linaro.org>
Cc: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Mark Brown <broonie@kernel.org>
Cc: Andy Green <andy@warmcat.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
Signed-off-by: Andy Green <andy.green@linaro.org>
[jstultz: Forward ported to mainline]
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
 drivers/dma/k3dma.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/k3dma.c b/drivers/dma/k3dma.c
index 39de898..3d51469 100644
--- a/drivers/dma/k3dma.c
+++ b/drivers/dma/k3dma.c
@@ -551,7 +551,7 @@ static int k3_dma_config(struct dma_chan *chan,
 	c->ccfg |= (val << 12) | (val << 16);
 
 	if ((maxburst == 0) || (maxburst > 16))
-		val = 16;
+		val = 15;
 	else
 		val = maxburst - 1;
 	c->ccfg |= (val << 20) | (val << 24);
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RESEND][PATCH 0/7 v4] K3DMA fixes for HiKey HDMI audio John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 6/7 v4] k3dma: Fix memory handling in preparation for cyclic mode John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 1/7 v4] Kconfig: Allow k3dma driver to be selected for more then HISI3xx platforms John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
    Re: [RESEND][PATCH 1/7 v4] Kconfig: Allow k3dma driver to be selected  for more then HISI3xx platforms John Stultz <john.stultz@linaro.org> - 2016-08-23 06:30 +0200
  [RESEND][PATCH 2/7 v4] k3dma: Fix hisi burst clipping John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 7/7 v4] k3dma: Add cyclic mode for audio John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 5/7 v4] k3dma: Fix occasional DMA ERR issue by using proper dma api John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 3/7 v4] k3dma: Fix dma err offsets John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200
  [RESEND][PATCH 4/7 v4] k3dma: Fix "nobody cared" message seen on any error John Stultz <john.stultz@linaro.org> - 2016-08-23 01:00 +0200

csiph-web