Re: [PATCH] acpi, nfit: check for the correct event code in notifications

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] acpi, nfit: check for the correct event code in notifications
Date	2016-08-23 00:50 +0200
Message-ID	<s96cy-3WR-11@gated-at.bofh.it> (permalink)
References	<s7YTL-1Yp-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Aug 19, 2016 at 1:40 PM, Vishal Verma <vishal.l.verma@intel.com> wrote:
> Commit 209851649dc4 "acpi: nfit: Add support for hot-add" added
> support for _FIT notifications, but it neglected to verify the
> notification event code matches the one in the ACPI spec for
> "NFIT Update". Currently there is only one code in the spec, but
> once additional codes are added, older kernels (without this fix)
> will misbehave by assuming all event notifications are for an
> NFIT Update.
>
> Fixes: 209851649dc4 ("acpi: nfit: Add support for hot-add")
> Cc: <stable@vger.kernel.org>
> Cc: <linux-acpi@vger.kernel.org>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Reported-by: Linda Knippers <linda.knippers@hpe.com>
> Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>

Looks good to me.  Given the lead time of spec changes I think this
can wait for the 4.9 merge window.  I'll add it to the -next branch.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] acpi, nfit: check for the correct event code in notifications Vishal Verma <vishal.l.verma@intel.com> - 2016-08-19 22:50 +0200
  Re: [PATCH] acpi, nfit: check for the correct event code in notifications Dan Williams <dan.j.williams@intel.com> - 2016-08-23 00:50 +0200

csiph-web