Re: [PATCH v6 3/4] SCT Write Same / DSM Trim

From	Tom Yan <tom.ty89@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6 3/4] SCT Write Same / DSM Trim
Date	2016-08-22 23:00 +0200
Message-ID	<s94u6-2Ol-35@gated-at.bofh.it> (permalink)
References	(3 earlier) <s8SVY-3V6-33@gated-at.bofh.it> <s8Z1o-7TZ-19@gated-at.bofh.it> <s90Tv-F4-1@gated-at.bofh.it> <s91Pz-1fk-21@gated-at.bofh.it> <s92BX-1yy-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 22 August 2016 at 18:52, Tom Yan <tom.ty89@gmail.com> wrote:
>
> For the "payload block size" that is "always" 512-byte as per the same
> spec, I don't think we need to concern about it. I think it only
> matters if we want to enable multi-block TRIM payload according to the
> reported limit in IDENTIFY DEVICE data. Probably it merely means that
> the "each of the blocks" in the reported limit will always mean 64
> TRIM entries, even on 4Kn drives, instead of 512.
>

Actually that's what we assumed in our current code that forms the DSM
command as well. See how (hob_)feature for queued TRIM and how
(hob_)nsect for non-queued TRIM are set in ata_scsi_write_same_xlat in
libata-scsi ('size / 512').

So if you are going to increase the payload block size per logical
sector size (in other word, you assume that the payload block size is
_expected_ to be the logical block size, in spite of what ACS told,
you'll need to adjust how the aforementioned fields in the ATA
taskfile are set as well.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v6 3/4] SCT Write Same / DSM Trim Shaun Tancheff <shaun@tancheff.com> - 2016-08-22 06:30 +0200
  Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Hannes Reinecke <hare@suse.de> - 2016-08-22 08:40 +0200
    [PATCH v6 3/4 RESEND] SCT Write Same / DSM Trim Shaun Tancheff <shaun@tancheff.com> - 2016-08-24 21:10 +0200
      Re: [PATCH v6 3/4 RESEND] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-25 09:20 +0200
        Re: [PATCH v6 3/4 RESEND] SCT Write Same / DSM Trim Shaun Tancheff <shaun.tancheff@seagate.com> - 2016-08-25 10:50 +0200
  Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-22 10:40 +0200
    Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-22 10:40 +0200
      Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Shaun Tancheff <shaun.tancheff@seagate.com> - 2016-08-22 17:10 +0200
        Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-22 19:10 +0200
          Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Shaun Tancheff <shaun.tancheff@seagate.com> - 2016-08-22 20:10 +0200
            Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-22 21:00 +0200
              Re: [PATCH v6 3/4] SCT Write Same / DSM Trim Tom Yan <tom.ty89@gmail.com> - 2016-08-22 23:00 +0200

csiph-web