Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1467846

Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings.

Show all headers | View raw

On Tue, Aug 23, 2016 at 12:54:17AM +0800, MingChia Chung wrote:
>   This patch fixes a minor checkpatch warnings:
> 
>   "WARNING: Block comments use a trailing */ on a separate line"
> 
>   Signed-off-by: Ming-Chia Chung <Quexint@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx.c | 42 ++++++++++++++++++++++++++++--------------
>  1 file changed, 28 insertions(+), 14 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index e992e03..a880411 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -81,14 +81,16 @@ static int slave_alloc(struct scsi_device *sdev)
>  
>  static int slave_configure(struct scsi_device *sdev)
>  {
> -	/* Scatter-gather buffers (all but the last) must have a length
> +	/*
> +   * Scatter-gather buffers (all but the last) must have a length

The alignment doesnot look correct here. Also in some more places later
in this patch.

regards
Sudip

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. MingChia Chung <quexint@gmail.com> - 2016-08-22 19:00 +0200
  Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-22 19:30 +0200
    Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. Ming-Chia Chung <quexint@gmail.com> - 2016-08-23 02:30 +0200
      Re: [PATCH] staging: rts5208: rtsx.c: Fix checkpatch warnings. Sudip Mukherjee <sudipm.mukherjee@gmail.com> - 2016-08-23 08:50 +0200

csiph-web