Re: ath9k: Fix beacon configuration assertion failure

From	Ioan-Adrian Ratiu <adi@adirat.com>
Newsgroups	linux.kernel
Subject	Re: ath9k: Fix beacon configuration assertion failure
Date	2016-08-22 18:30 +0200
Message-ID	<s90gO-ck-65@gated-at.bofh.it> (permalink)
References	<s7O81-3Ld-7@gated-at.bofh.it> <s7OUq-4gK-25@gated-at.bofh.it> <s8T5D-3Zg-1@gated-at.bofh.it> <s8XCh-6TY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, 22 Aug 2016, Kalle Valo <kvalo@codeaurora.org> wrote:
> Benjamin Berg <benjamin.berg@open-mesh.com> writes:
>
>> On Fr, 2016-08-19 at 13:03 +0300, Kalle Valo wrote:
>>> Actually, I see two patches which might be related but not identical:
>>> 
>>> ath9k: fix client mode beacon configuration
>>> https://patchwork.kernel.org/patch/9247699/
>>> 
>>> ath9k: Fix beacon configuration assertion failure
>>> https://patchwork.kernel.org/patch/9281191/
>>> 
>>> Felix (CCed) & Benjamin: please take a look and advice which one I
>>> should take.
>>
>> Yes, both patches are designed to fix the same issue in my patch.
>>
>> Felix solution looks entirely correct to me, the second solution seems
>> slightly wrong because it prevents the call to ath9k_beacon_config from
>> happening instead of ensuring the correct parameter value.
>> ath9k_beacon_config needs to be called even if iter_data.beacons is
>> false as it disables the interrupts.
>
> Ok, I'll the patch from Felix then. Thanks.

Tested Felix patch. Confirm it works great. Thanks!

>
> -- 
> Kalle Valo

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ath9k: Fix beacon configuration assertion failure Ioan-Adrian Ratiu <adi@adirat.com> - 2016-08-15 17:10 +0200
  Re: ath9k: Fix beacon configuration assertion failure Kalle Valo <kvalo@qca.qualcomm.com> - 2016-08-19 11:20 +0200
    Re: ath9k: Fix beacon configuration assertion failure Kalle Valo <kvalo@codeaurora.org> - 2016-08-19 12:10 +0200
      Re: ath9k: Fix beacon configuration assertion failure Ioan-Adrian Ratiu <adi@adirat.com> - 2016-08-19 13:10 +0200
      Re: ath9k: Fix beacon configuration assertion failure Benjamin Berg <benjamin.berg@open-mesh.com> - 2016-08-22 10:50 +0200
        Re: ath9k: Fix beacon configuration assertion failure Kalle Valo <kvalo@codeaurora.org> - 2016-08-22 15:40 +0200
          Re: ath9k: Fix beacon configuration assertion failure Ioan-Adrian Ratiu <adi@adirat.com> - 2016-08-22 18:30 +0200

csiph-web